From: Bruno Randolf <br1@einfach.org>
To: Bob Copeland <me@bobcopeland.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
linville@tuxdriver.com
Subject: Re: [ath5k-devel] [PATCH] ath5k: disable all tasklets while resetting
Date: Mon, 14 Jun 2010 10:50:59 +0900 [thread overview]
Message-ID: <201006141050.59607.br1@einfach.org> (raw)
In-Reply-To: <AANLkTik0Q2JM_DNaiLxc33Nn6dpI6uT52uG7b8-F4QjW@mail.gmail.com>
On Friday 11 June 2010 23:38:15 Bob Copeland wrote:
> On Fri, Jun 11, 2010 at 10:21 AM, Bob Copeland <me@bobcopeland.com> wrote:
> > On Fri, Jun 11, 2010 at 6:41 AM, Johannes Berg
> >
> > <johannes@sipsolutions.net> wrote:
> >> I have no idea how long a reset can take, but this means that all these
> >> tasklets will spin while your reset is running if they were scheduled.
> >
> > It looks to me like tasklet_action() will bail out when the tasklet has a
> > positive t->count (which disable elevates) rather than spin. What did I
> > miss?
>
> As Johannes pointed out on irc, I missed that it re-raises the softirq.
> doh!
well, what else can we do? we have to make sure the tasklets don't run
concurrently to a reset to keep rx and tx buffers consistent.
we disable interrupts right after disabling the tasklets, so they should not
be scheduled again, right? actually, we should disable interrupts first, and
then disable tasklets... but then it should be safe, no?
bruno
next prev parent reply other threads:[~2010-06-14 1:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 10:12 [PATCH] ath5k: disable all tasklets while resetting Bruno Randolf
2010-06-11 10:41 ` Johannes Berg
2010-06-11 14:21 ` [ath5k-devel] " Bob Copeland
2010-06-11 14:38 ` Bob Copeland
2010-06-14 1:50 ` Bruno Randolf [this message]
2010-06-14 11:43 ` Bob Copeland
2010-06-15 1:07 ` Bruno Randolf
2010-06-15 4:10 ` Bob Copeland
2010-06-15 4:54 ` Bruno Randolf
2010-06-15 11:21 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006141050.59607.br1@einfach.org \
--to=br1@einfach.org \
--cc=ath5k-devel@lists.ath5k.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).