From: Bob Copeland <me@bobcopeland.com>
To: Bruno Randolf <br1@einfach.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
linville@tuxdriver.com
Subject: Re: [ath5k-devel] [PATCH] ath5k: disable all tasklets while resetting
Date: Tue, 15 Jun 2010 00:10:16 -0400 [thread overview]
Message-ID: <20100615041016.GA13984@hash.localnet> (raw)
In-Reply-To: <201006151007.21708.br1@einfach.org>
On Tue, Jun 15, 2010 at 10:07:21AM +0900, Bruno Randolf wrote:
> On Mon June 14 2010 20:43:02 you wrote:
> > On Mon, Jun 14, 2010 at 10:50:59AM +0900, Bruno Randolf wrote:
> > > we disable interrupts right after disabling the tasklets, so they should
> > > not be scheduled again, right? actually, we should disable interrupts
> > > first, and then disable tasklets... but then it should be safe, no?
> >
> > Disable interrupts then tasklet_kill should do it.
>
> what's wrong with first disable interrupts and tasklet_disable?
Look at the code for tasklet_disable... it only waits for tasks that
are in the run state but doesn't do anything for scheduled tasks.
So you can still get the spinning behavior if the interrupt runs and
schedules the tasklet on another CPU.
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2010-06-15 4:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 10:12 [PATCH] ath5k: disable all tasklets while resetting Bruno Randolf
2010-06-11 10:41 ` Johannes Berg
2010-06-11 14:21 ` [ath5k-devel] " Bob Copeland
2010-06-11 14:38 ` Bob Copeland
2010-06-14 1:50 ` Bruno Randolf
2010-06-14 11:43 ` Bob Copeland
2010-06-15 1:07 ` Bruno Randolf
2010-06-15 4:10 ` Bob Copeland [this message]
2010-06-15 4:54 ` Bruno Randolf
2010-06-15 11:21 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100615041016.GA13984@hash.localnet \
--to=me@bobcopeland.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=br1@einfach.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).