From: Bob Copeland <me@bobcopeland.com>
To: Bruno Randolf <br1@einfach.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
linville@tuxdriver.com
Subject: Re: [ath5k-devel] [PATCH] ath5k: disable all tasklets while resetting
Date: Tue, 15 Jun 2010 07:21:07 -0400 [thread overview]
Message-ID: <20100615112107.GB13984@hash.localnet> (raw)
In-Reply-To: <201006151354.43744.br1@einfach.org>
On Tue, Jun 15, 2010 at 01:54:43PM +0900, Bruno Randolf wrote:
> if we disable interrupts in the chip (ath5k_hw_set_imr) , the hardware does
> not generate any interrupts. so no tasklets will get scheduled...
The tasklet might already be scheduled on another CPU:
cpu0 cpu1
ath5k_reset()
ath5k_intr()
ath5k_hw_set_imr(0)
synchronize_irq()
// spins until irq finishes
tasklet_schedule(foo)
tasklet_disable(foo)
// reset here
tasklet_action() // spins
--
Bob Copeland %% www.bobcopeland.com
prev parent reply other threads:[~2010-06-15 11:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 10:12 [PATCH] ath5k: disable all tasklets while resetting Bruno Randolf
2010-06-11 10:41 ` Johannes Berg
2010-06-11 14:21 ` [ath5k-devel] " Bob Copeland
2010-06-11 14:38 ` Bob Copeland
2010-06-14 1:50 ` Bruno Randolf
2010-06-14 11:43 ` Bob Copeland
2010-06-15 1:07 ` Bruno Randolf
2010-06-15 4:10 ` Bob Copeland
2010-06-15 4:54 ` Bruno Randolf
2010-06-15 11:21 ` Bob Copeland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100615112107.GB13984@hash.localnet \
--to=me@bobcopeland.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=br1@einfach.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).