Re: [PATCH 2.6.32.y] ath9k: re-enable ps by default for new single chip families

["Luis R. Rodriguez" <lrodriguez@atheros.com>]

On Wed, Jun 16, 2010 at 09:01:36AM -0700, Justin P. Mattock wrote:
> On 06/16/2010 08:49 AM, Luis R. Rodriguez wrote:
> > On Wed, Jun 16, 2010 at 6:33 AM, Justin P. Mattock
> > <justinmattock@gmail.com>  wrote:
> >> On 06/16/2010 01:12 AM, Kristoffer Ericson wrote:
> >>>
> >>> On Tue, Jun 15, 2010 at 06:19:19PM -0400, Luis R. Rodriguez wrote:
> >>>>
> >>>> commit 14acdde6e527950f66c084dbf19bad6fbfcaeedc upstream.
> >>>>
> >>>> The newer single chip hardware family of chipsets have not been
> >>>> experiencing issues with power saving set by default with recent
> >>>> fixes merged (even into stable). The remaining issues are only
> >>>> reported with AR5416 and since enabling PS by default can increase
> >>>> power savings considerably best to take advantage of that feature
> >>>> as this has been tested properly.
> >>>
> >>> I havent had any issues lately. But that said Ive moved on to
> >>> 2.6.33, 2.6.34 which seems to work fine. Believe you set
> >>> to disabled by default on those?
> >>>
> >>> /Kristoffer
> >>>
> >>
> >> just tried to add this patch to the latest HEAD, but realized
> >> ath_set_hw_capab is missing(or I cant seem to grep it)
> >> if you have a patch for the latest tree let me know I can see if I'm hitting
> >> anything like before.
> >
> > The patch would already be merged since 2.6.33.y, this patch is a
> > backport for 2.6.32.y. I just hadn't had time to backport it yet,
> > until today.
> >
> >    Luis
> >
> 
> so its already in there then..

Right

> if that's the case then the system runs 
> good with powersave on then..

Did you read the patch by chance? It only enables power save for
non-AR5416 hardware. What do you have?
 
  Luis