linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCHv2] mac80211: Add interface for driver to temporarily disable dynamic ps
Date: Wed, 16 Jun 2010 14:57:06 -0400	[thread overview]
Message-ID: <20100616185706.GC3138@tuxdriver.com> (raw)
In-Reply-To: <1276668092-28872-1-git-send-email-juuso.oikarinen@nokia.com>

On Wed, Jun 16, 2010 at 09:01:32AM +0300, Juuso Oikarinen wrote:
> This mechanism introduced in this patch applies (at least) for hardware
> designs using a single shared antenna for both WLAN and BT. In these designs,
> the antenna must be toggled between WLAN and BT.
> 
> In those hardware, managing WLAN co-existence with Bluetooth requires WLAN
> full power save whenever there is Bluetooth activity in order for WLAN to be
> able to periodically relinquish the antenna to be used for BT. This is because
> BT can only access the shared antenna when WLAN is idle or asleep.

Maybe it is just me, but

void ieee80211_enable_dyn_ps(struct ieee80211_vif *vif)
void ieee80211_disable_dyn_ps(struct ieee80211_vif *vif)

would make more sense than

void ieee80211_disable_dyn_ps(struct ieee80211_vif *vif, bool disable)

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  reply	other threads:[~2010-06-16 19:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-16  6:01 [PATCHv2] mac80211: Add interface for driver to temporarily disable dynamic ps Juuso Oikarinen
2010-06-16 18:57 ` John W. Linville [this message]
2010-06-17  4:49   ` Juuso Oikarinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100616185706.GC3138@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=juuso.oikarinen@nokia.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).