From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: "linville@tuxdriver.com" <linville@tuxdriver.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/3] ath9k: Restore ps state in ath_paprd_calibrate() upon failure to allocate skb
Date: Thu, 24 Jun 2010 16:31:08 +0530 [thread overview]
Message-ID: <20100624110107.GA6339@vasanth-laptop> (raw)
In-Reply-To: <1277372566-22883-2-git-send-email-vasanth@atheros.com>
On Thu, Jun 24, 2010 at 03:12:45PM +0530, Vasanthakumar Thiagarajan wrote:
> Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
> ---
> drivers/net/wireless/ath/ath9k/main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
> index 6d57877..484d113 100644
> --- a/drivers/net/wireless/ath/ath9k/main.c
> +++ b/drivers/net/wireless/ath/ath9k/main.c
> @@ -271,7 +271,7 @@ void ath_paprd_calibrate(struct work_struct *work)
> ath9k_ps_wakeup(sc);
> skb = alloc_skb(len, GFP_KERNEL);
> if (!skb)
> - return;
> + goto fail_paprd;
>
> tx_info = IEEE80211_SKB_CB(skb);
Please drop this particular patch, ath9k_ps_wakeup() does not need
to be there before alloc_skb() in the first place. I'll send a cleaner one.
Vasanth
next prev parent reply other threads:[~2010-06-24 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 9:42 [PATCH 1/3] ath9k: Fix bug in paprd Vasanthakumar Thiagarajan
2010-06-24 9:42 ` [PATCH 2/3] ath9k: Restore ps state in ath_paprd_calibrate() upon failure to allocate skb Vasanthakumar Thiagarajan
2010-06-24 11:01 ` Vasanthakumar Thiagarajan [this message]
2010-06-24 9:42 ` [PATCH 3/3] ath9k: Remove unused paprd_txok Vasanthakumar Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100624110107.GA6339@vasanth-laptop \
--to=vasanth@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).