Fwd: mesh configuration information element is wrong?

Fwd: mesh configuration information element is wrong?

[Iuri Diniz]

Hello folks,

I'm analyzing the 802.11s code and I think I've found that mesh
configuration information element has wrongs sizes.

It is not according to my copy of 802.11s draft 3.

on linux-wireless-testing/linux/include/ieee80211.h we have:
--------
/**
 * struct ieee80211_meshconf_ie
 *
 * This structure refers to "Mesh Configuration information element"
 */
struct ieee80211_meshconf_ie {
    u8 meshconf_psel;
    u8 meshconf_pmetric;
    u8 meshconf_congest;
    u8 meshconf_synch;
    u8 meshconf_auth;
    u8 meshconf_form;
    u8 meshconf_cap;
} __attribute__ ((packed));
----------

All fields have 1 byte, but according to
http://i45.tinypic.com/4ghhd1.jpg some of they must have 4 or 2 bytes

the function mesh.c:mesh_mgmt_ies_add uses those wrong sizes to
prepare the management frame.

Is there a new draft? or is there any reason to use those sizes?

(March 2009) Draft 3 802.11s MESH CONFIGURATION ELEMENT:
http://i45.tinypic.com/4ghhd1.jpg

--
Iuri Diniz
http://iuridiniz.com [Sou um agitador, não um advogado]
http://blog.igdium.com [Linux on Limbo]

Re: mesh configuration information element is wrong?

[Iuri Diniz]

On Fri, Jun 25, 2010 at 2:43 PM, Iuri Diniz <iuridiniz@gmail.com> wrote:
> I'm analyzing the 802.11s code and I think I've found that mesh
> configuration information element has wrongs sizes.
>
> It is not according to my copy of 802.11s draft 3.

It seems that (in the past) the code had that sizes I think right.

http://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=blobdiff;f=net/mac80211/mesh.c;h=c8a4f19ed13bb810a97bb5e25200a74cdd55a31c;hp=79425182c2903a70f355f1bdb34fe9fe8239fe05;hb=10f8f42ece65ba964ca14e794e5f45ad98d56cf1;hpb=8f2fda9594f083981ad54c1994863875fe680925

so I'll assume that the last draft has changed the size of this IE.

But could someone with access to the last draft draft confirm it?

Sorry for annoying you guys, I don't have the last draft.

-- 
Iuri Diniz
http://iuridiniz.com [Sou um agitador, não um advogado]
http://blog.igdium.com [Linux on Limbo]

Re: Fwd: mesh configuration information element is wrong?

[Jouni Malinen]

On Fri, Jun 25, 2010 at 02:43:31PM -0300, Iuri Diniz wrote:

> I'm analyzing the 802.11s code and I think I've found that mesh
> configuration information element has wrongs sizes.
> 
> It is not according to my copy of 802.11s draft 3.

Draft 3 is quite old..

> on linux-wireless-testing/linux/include/ieee80211.h we have:
>  * struct ieee80211_meshconf_ie
>  * This structure refers to "Mesh Configuration information element"

> struct ieee80211_meshconf_ie {
>     u8 meshconf_psel;
>     u8 meshconf_pmetric;
>     u8 meshconf_congest;
>     u8 meshconf_synch;
>     u8 meshconf_auth;
>     u8 meshconf_form;
>     u8 meshconf_cap;
> } __attribute__ ((packed));

That matches otherwise with the latest draft (P802.11s/D6.0), but it
lacks one field. There is a 1-octet field "Mesh Peering Protocol
Identifier" between the _auth and _form fields in the latest draft.

-- 
Jouni Malinen                                            PGP id EFC895FA

Re: Fwd: mesh configuration information element is wrong?

[Iuri Diniz]

On Sat, Jun 26, 2010 at 12:08 PM, Jouni Malinen <j@w1.fi> wrote:
> Draft 3 is quite old..
>

Do you know if I buy Draft 6, it will be full (last complete reference
about 802.11s) or will only be only a "diff" to draft 5?


-- 
Iuri Diniz