* Re: FYI: needlessly exported symbols
2010-02-19 9:40 FYI: needlessly exported symbols Johannes Berg
@ 2010-02-19 14:16 ` Christian Lamparter
2010-02-19 14:19 ` Johannes Berg
2010-06-29 19:38 ` [PATCH] ath9k: remove unused function ath9k_hw_keyisvalid John W. Linville
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Christian Lamparter @ 2010-02-19 14:16 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, Luis R. Rodriguez, Chatre, Reinette
On Fri, Feb 19, 2010 at 10:40 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> According to a little analysis I did on wireless-testing, these symbols
> need not be exported because they're not imported by any module:
>
> p54_parse_eeprom
p54spi(.ko) needs p54_parse_eeprom from p54common(.ko)
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: FYI: needlessly exported symbols
2010-02-19 14:16 ` Christian Lamparter
@ 2010-02-19 14:19 ` Johannes Berg
0 siblings, 0 replies; 8+ messages in thread
From: Johannes Berg @ 2010-02-19 14:19 UTC (permalink / raw)
To: Christian Lamparter; +Cc: linux-wireless, Luis R. Rodriguez, Chatre, Reinette
[-- Attachment #1: Type: text/plain, Size: 445 bytes --]
On Fri, 2010-02-19 at 15:16 +0100, Christian Lamparter wrote:
> On Fri, Feb 19, 2010 at 10:40 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > According to a little analysis I did on wireless-testing, these
> symbols
> > need not be exported because they're not imported by any module:
> >
> > p54_parse_eeprom
>
> p54spi(.ko) needs p54_parse_eeprom from p54common(.ko)
Ah. I must have not built that p54spi.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ath9k: remove unused function ath9k_hw_keyisvalid
2010-02-19 9:40 FYI: needlessly exported symbols Johannes Berg
2010-02-19 14:16 ` Christian Lamparter
@ 2010-06-29 19:38 ` John W. Linville
2010-06-29 19:39 ` [PATCH] ath9k: make ath9k_hw_keysetmac static John W. Linville
2010-06-29 19:39 ` [PATCH] iwlwifi: do not export iwl_leds_background John W. Linville
3 siblings, 0 replies; 8+ messages in thread
From: John W. Linville @ 2010-06-29 19:38 UTC (permalink / raw)
To: linux-wireless; +Cc: Johannes Berg, ath9k-devel, John W. Linville
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/net/wireless/ath/ath9k/hw.c | 11 -----------
drivers/net/wireless/ath/ath9k/hw.h | 1 -
2 files changed, 0 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
index 1ed1440..9d22444 100644
--- a/drivers/net/wireless/ath/ath9k/hw.c
+++ b/drivers/net/wireless/ath/ath9k/hw.c
@@ -1737,17 +1737,6 @@ bool ath9k_hw_set_keycache_entry(struct ath_hw *ah, u16 entry,
}
EXPORT_SYMBOL(ath9k_hw_set_keycache_entry);
-bool ath9k_hw_keyisvalid(struct ath_hw *ah, u16 entry)
-{
- if (entry < ah->caps.keycache_size) {
- u32 val = REG_READ(ah, AR_KEYTABLE_MAC1(entry));
- if (val & AR_KEYTABLE_VALID)
- return true;
- }
- return false;
-}
-EXPORT_SYMBOL(ath9k_hw_keyisvalid);
-
/******************************/
/* Power Management (Chipset) */
/******************************/
diff --git a/drivers/net/wireless/ath/ath9k/hw.h b/drivers/net/wireless/ath/ath9k/hw.h
index e9578a4..f0e0cc9 100644
--- a/drivers/net/wireless/ath/ath9k/hw.h
+++ b/drivers/net/wireless/ath/ath9k/hw.h
@@ -863,7 +863,6 @@ bool ath9k_hw_keysetmac(struct ath_hw *ah, u16 entry, const u8 *mac);
bool ath9k_hw_set_keycache_entry(struct ath_hw *ah, u16 entry,
const struct ath9k_keyval *k,
const u8 *mac);
-bool ath9k_hw_keyisvalid(struct ath_hw *ah, u16 entry);
/* GPIO / RFKILL / Antennae */
void ath9k_hw_cfg_gpio_input(struct ath_hw *ah, u32 gpio);
--
1.7.0.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] ath9k: make ath9k_hw_keysetmac static
2010-02-19 9:40 FYI: needlessly exported symbols Johannes Berg
2010-02-19 14:16 ` Christian Lamparter
2010-06-29 19:38 ` [PATCH] ath9k: remove unused function ath9k_hw_keyisvalid John W. Linville
@ 2010-06-29 19:39 ` John W. Linville
2010-06-29 19:39 ` [PATCH] iwlwifi: do not export iwl_leds_background John W. Linville
3 siblings, 0 replies; 8+ messages in thread
From: John W. Linville @ 2010-06-29 19:39 UTC (permalink / raw)
To: linux-wireless; +Cc: Johannes Berg, ath9k-devel, John W. Linville
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/net/wireless/ath/ath9k/hw.c | 3 +--
drivers/net/wireless/ath/ath9k/hw.h | 1 -
2 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
index 9d22444..6e87af4 100644
--- a/drivers/net/wireless/ath/ath9k/hw.c
+++ b/drivers/net/wireless/ath/ath9k/hw.c
@@ -1498,7 +1498,7 @@ bool ath9k_hw_keyreset(struct ath_hw *ah, u16 entry)
}
EXPORT_SYMBOL(ath9k_hw_keyreset);
-bool ath9k_hw_keysetmac(struct ath_hw *ah, u16 entry, const u8 *mac)
+static bool ath9k_hw_keysetmac(struct ath_hw *ah, u16 entry, const u8 *mac)
{
u32 macHi, macLo;
u32 unicast_flag = AR_KEYTABLE_VALID;
@@ -1536,7 +1536,6 @@ bool ath9k_hw_keysetmac(struct ath_hw *ah, u16 entry, const u8 *mac)
return true;
}
-EXPORT_SYMBOL(ath9k_hw_keysetmac);
bool ath9k_hw_set_keycache_entry(struct ath_hw *ah, u16 entry,
const struct ath9k_keyval *k,
diff --git a/drivers/net/wireless/ath/ath9k/hw.h b/drivers/net/wireless/ath/ath9k/hw.h
index f0e0cc9..bb99e2e 100644
--- a/drivers/net/wireless/ath/ath9k/hw.h
+++ b/drivers/net/wireless/ath/ath9k/hw.h
@@ -859,7 +859,6 @@ u32 ath9k_regd_get_ctl(struct ath_regulatory *reg, struct ath9k_channel *chan);
/* Key Cache Management */
bool ath9k_hw_keyreset(struct ath_hw *ah, u16 entry);
-bool ath9k_hw_keysetmac(struct ath_hw *ah, u16 entry, const u8 *mac);
bool ath9k_hw_set_keycache_entry(struct ath_hw *ah, u16 entry,
const struct ath9k_keyval *k,
const u8 *mac);
--
1.7.0.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] iwlwifi: do not export iwl_leds_background
2010-02-19 9:40 FYI: needlessly exported symbols Johannes Berg
` (2 preceding siblings ...)
2010-06-29 19:39 ` [PATCH] ath9k: make ath9k_hw_keysetmac static John W. Linville
@ 2010-06-29 19:39 ` John W. Linville
2010-06-29 20:18 ` reinette chatre
3 siblings, 1 reply; 8+ messages in thread
From: John W. Linville @ 2010-06-29 19:39 UTC (permalink / raw)
To: linux-wireless; +Cc: Johannes Berg, Reinette Chatre, John W. Linville
It is only used from within the iwlcore module.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/net/wireless/iwlwifi/iwl-led.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-led.c b/drivers/net/wireless/iwlwifi/iwl-led.c
index db5bfcb..486244b 100644
--- a/drivers/net/wireless/iwlwifi/iwl-led.c
+++ b/drivers/net/wireless/iwlwifi/iwl-led.c
@@ -214,7 +214,6 @@ void iwl_leds_background(struct iwl_priv *priv)
priv->last_blink_time = jiffies;
priv->last_blink_rate = blink_idx;
}
-EXPORT_SYMBOL(iwl_leds_background);
void iwl_leds_init(struct iwl_priv *priv)
{
--
1.7.0.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] iwlwifi: do not export iwl_leds_background
2010-06-29 19:39 ` [PATCH] iwlwifi: do not export iwl_leds_background John W. Linville
@ 2010-06-29 20:18 ` reinette chatre
2010-06-29 20:32 ` John W. Linville
0 siblings, 1 reply; 8+ messages in thread
From: reinette chatre @ 2010-06-29 20:18 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless@vger.kernel.org, Johannes Berg
On Tue, 2010-06-29 at 12:39 -0700, John W. Linville wrote:
> It is only used from within the iwlcore module.
>
> Reported-by: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> drivers/net/wireless/iwlwifi/iwl-led.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-led.c b/drivers/net/wireless/iwlwifi/iwl-led.c
> index db5bfcb..486244b 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-led.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-led.c
> @@ -214,7 +214,6 @@ void iwl_leds_background(struct iwl_priv *priv)
> priv->last_blink_time = jiffies;
> priv->last_blink_rate = blink_idx;
> }
> -EXPORT_SYMBOL(iwl_leds_background);
>
> void iwl_leds_init(struct iwl_priv *priv)
> {
Nack.
Please take a closer look at how it is used ... it is used in iwl-core.h
in an inline (iwl_update_stats) function that is used by both iwlagn and
iwl3945.
Reinette
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] iwlwifi: do not export iwl_leds_background
2010-06-29 20:18 ` reinette chatre
@ 2010-06-29 20:32 ` John W. Linville
0 siblings, 0 replies; 8+ messages in thread
From: John W. Linville @ 2010-06-29 20:32 UTC (permalink / raw)
To: reinette chatre; +Cc: linux-wireless@vger.kernel.org, Johannes Berg
On Tue, Jun 29, 2010 at 01:18:59PM -0700, reinette chatre wrote:
> On Tue, 2010-06-29 at 12:39 -0700, John W. Linville wrote:
> > It is only used from within the iwlcore module.
> >
> > Reported-by: Johannes Berg <johannes@sipsolutions.net>
> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
> > ---
> > drivers/net/wireless/iwlwifi/iwl-led.c | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/net/wireless/iwlwifi/iwl-led.c b/drivers/net/wireless/iwlwifi/iwl-led.c
> > index db5bfcb..486244b 100644
> > --- a/drivers/net/wireless/iwlwifi/iwl-led.c
> > +++ b/drivers/net/wireless/iwlwifi/iwl-led.c
> > @@ -214,7 +214,6 @@ void iwl_leds_background(struct iwl_priv *priv)
> > priv->last_blink_time = jiffies;
> > priv->last_blink_rate = blink_idx;
> > }
> > -EXPORT_SYMBOL(iwl_leds_background);
> >
> > void iwl_leds_init(struct iwl_priv *priv)
> > {
>
> Nack.
>
> Please take a closer look at how it is used ... it is used in iwl-core.h
> in an inline (iwl_update_stats) function that is used by both iwlagn and
> iwl3945.
OK
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 8+ messages in thread