From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] mac80211: Dont allow to wake up netif tx queues while on off channel
Date: Wed, 30 Jun 2010 03:51:19 -0700 [thread overview]
Message-ID: <20100630105118.GB2192@vasanth-laptop> (raw)
In-Reply-To: <1277893571.7823.9.camel@jlt3.sipsolutions.net>
On Wed, Jun 30, 2010 at 03:56:11PM +0530, Johannes Berg wrote:
> On Wed, 2010-06-30 at 12:17 +0200, Johannes Berg wrote:
> > On Wed, 2010-06-30 at 03:15 -0700, Vasanthakumar Thiagarajan wrote:
> > > Drivers are not supposed to call ieee80211_wake_queue() while operating
> > > on off channel during sw scanning,
>
> > That doesn't seem to make sense, since we treat driver and scan stop
> > status separately via wake_queue_by_reason()
>
> IOW, the above assertion would seem to be false already.
Sorry, I mean the existing code assumes that ieee80211_wake_queue() while
operating on off channel during scanning.
Vasanth
next prev parent reply other threads:[~2010-06-30 10:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 10:15 [PATCH 1/2] mac80211: Dont allow to wake up netif tx queues while on off channel Vasanthakumar Thiagarajan
2010-06-30 10:17 ` Johannes Berg
2010-06-30 10:26 ` Johannes Berg
2010-06-30 10:51 ` Vasanthakumar Thiagarajan [this message]
2010-06-30 10:57 ` Vasanthakumar Thiagarajan
2010-06-30 10:47 ` Vasanthakumar Thiagarajan
2010-07-01 9:34 ` Vasanthakumar Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100630105118.GB2192@vasanth-laptop \
--to=vasanth@atheros.com \
--cc=Vasanth.Thiagarajan@Atheros.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).