From: Dan Carpenter <error27@gmail.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Simon Kelley <simon@thekelleys.org.uk>,
"John W. Linville" <linville@tuxdriver.com>,
"David S. Miller" <davem@davemloft.net>,
Stephen Hemminger <shemminger@vyatta.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Ben Hutchings <ben@decadent.org.uk>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] atmel: unregister_netdev() on error
Date: Sat, 10 Jul 2010 16:12:04 +0200 [thread overview]
Message-ID: <20100710141204.GY19184@bicker> (raw)
In-Reply-To: <1278767508-10164-1-git-send-email-segooon@gmail.com>
On Sat, Jul 10, 2010 at 05:11:47PM +0400, Kulikov Vasiliy wrote:
> We must unregister registered device if probe_atmel_card() fails.
I think you hit send accidentally on this one?
> if (!probe_atmel_card(dev)) {
> unregister_netdev(dev);
^^^^^^^^^^^^^^^^^^^^^^^
> - goto err_out_res;
> + goto err_out_unreg;
> }
>
> netif_carrier_off(dev);
> @@ -1640,6 +1640,9 @@ struct net_device *init_atmel_card(unsigned short irq, unsigned long port,
>
> return dev;
>
> +err_out_unreg:
> + unregister_netdev(dev);
^^^^^^^^^^^^^^^^^^^^^^
> +
What the pants? :P
regards,
dan carpenter
next prev parent reply other threads:[~2010-07-10 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-10 13:11 [PATCH] atmel: unregister_netdev() on error Kulikov Vasiliy
2010-07-10 14:12 ` Dan Carpenter [this message]
2010-07-10 16:38 ` Kulikov Vasiliy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100710141204.GY19184@bicker \
--to=error27@gmail.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=segooon@gmail.com \
--cc=shemminger@vyatta.com \
--cc=simon@thekelleys.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).