From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Bob Copeland <me@bobcopeland.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"br1@einfach.org" <br1@einfach.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath5k-devel@lists.ath5k.org" <ath5k-devel@lists.ath5k.org>,
"jirislaby@gmail.com" <jirislaby@gmail.com>,
"mickflemm@gmail.com" <mickflemm@gmail.com>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>
Subject: Re: [PATCH 1/2] ath5k: move reset to mac80211 workqueue
Date: Tue, 13 Jul 2010 10:39:06 -0700 [thread overview]
Message-ID: <20100713173906.GB11519@tux> (raw)
In-Reply-To: <1279035161-10802-1-git-send-email-me@bobcopeland.com>
On Tue, Jul 13, 2010 at 08:32:40AM -0700, Bob Copeland wrote:
> We currently trigger a reset via a tasklet when certain error
> conditions are detected so that the card will (eventually)
> restart. Unfortunately this makes locking complicated since
> reset can also be called in process context (e.g. for channel
> change). Currently nothing protects against concurrent resets,
> which can be the source of corruption bugs.
>
> Reset takes too long to spinlock the whole thing, so this
> patch moves deferred resets into the mac80211 workqueue to
> enable use of sc->lock mutex.
>
> Signed-off-by: Bob Copeland <me@bobcopeland.com>
Neat! Good idea.
Luis
next prev parent reply other threads:[~2010-07-13 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 15:32 [PATCH 1/2] ath5k: move reset to mac80211 workqueue Bob Copeland
2010-07-13 15:32 ` [PATCH 2/2] ath5k: disable tasklets during reset Bob Copeland
2010-07-14 1:35 ` Bruno Randolf
2010-07-13 17:39 ` Luis R. Rodriguez [this message]
2010-07-14 1:35 ` [PATCH 1/2] ath5k: move reset to mac80211 workqueue Bruno Randolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100713173906.GB11519@tux \
--to=lrodriguez@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=br1@einfach.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).