From: "John W. Linville" <linville@tuxdriver.com>
To: Ivo Van Doorn <ivdoorn@gmail.com>
Cc: Christoph Egger <siccegge@cs.fau.de>,
Gertjan van Wingerde <gwingerde@gmail.com>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Felix Fietkau <nbd@openwrt.org>,
Helmut Schaa <helmut.schaa@googlemail.com>,
linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
vamos-dev@i4.informatik.uni-erlangen.de,
Luis Correia <luis.f.correia@gmail.com>
Subject: Re: [PATCH 01/11] Removing dead RT2800PCI_SOC
Date: Wed, 14 Jul 2010 09:15:27 -0400 [thread overview]
Message-ID: <20100714131527.GB2352@tuxdriver.com> (raw)
In-Reply-To: <AANLkTikCeDys9e1EnE9GdiJtDRcbqW3gzvsmjzvB_yDs@mail.gmail.com>
On Wed, Jul 14, 2010 at 02:52:14PM +0200, Ivo Van Doorn wrote:
> On Wed, Jul 14, 2010 at 2:46 PM, Luis Correia <luis.f.correia@gmail.com> wrote:
> > On Wed, Jul 14, 2010 at 13:39, Christoph Egger <siccegge@cs.fau.de> wrote:
> >> While RT2800PCI_SOC exists in Kconfig, it depends on either
> >> RALINK_RT288X or RALINK_RT305X which are both not available in Kconfig
> >> so all Code depending on that can't ever be selected and, if there's
> >> no plan to add these options, should be cleaned up
> >>
> >> Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
> >
> > NAK,
> >
> > this is not dead code, it is needed for the Ralink System-on-Chip
> > Platform devices.
> >
> > While I can't fix Kconfig errors and the current KConfig file may be
> > wrong, this code cannot and will not be deleted.
>
> When the config option was introduced, the config options RALINK_RT288X and
> RALINK_RT305X were supposed to be merged as well soon after by somebody (Felix?)
>
> But since testing is done on SoC boards by Helmut and Felix, I assume the code
> isn't dead but actually in use.
Perhaps Helmut and Felix can send us the missing code?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-07-14 13:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 12:39 [PATCH 00/11] Removing dead code Christoph Egger
2010-07-14 12:39 ` [PATCH 01/11] Removing dead RT2800PCI_SOC Christoph Egger
2010-07-14 12:46 ` Luis Correia
2010-07-14 12:52 ` Ivo Van Doorn
2010-07-14 13:15 ` John W. Linville [this message]
2010-07-14 14:44 ` Felix Fietkau
2010-07-15 8:41 ` Bartlomiej Zolnierkiewicz
[not found] ` <AANLkTilqoYMMKYJT-YYbEzdnytUSYa0EylEiJ4x5xXXH@mail.gmail.com>
2010-07-16 7:18 ` Gertjan van Wingerde
2010-07-16 10:08 ` Helmut Schaa
2010-07-16 15:46 ` Gertjan van Wingerde
2010-07-16 17:44 ` Helmut Schaa
2010-07-14 14:14 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100714131527.GB2352@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=bzolnier@gmail.com \
--cc=gwingerde@gmail.com \
--cc=helmut.schaa@googlemail.com \
--cc=ivdoorn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luis.f.correia@gmail.com \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=siccegge@cs.fau.de \
--cc=users@rt2x00.serialmonkey.com \
--cc=vamos-dev@i4.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).