From: "John W. Linville" <linville@tuxdriver.com>
To: yogeshp <yogeshp@marvell.com>
Cc: Nishant Sarmukadam <nishants@marvell.com>,
Pradeep Nemavat <pnemavat@marvell.com>,
linux-wireless@vger.kernel.org
Subject: Re: [RFC] mac80211: indicate BA window size with IEEE80211_AMPDU_TX_OPERATIONAL drv_ampud_action
Date: Thu, 15 Jul 2010 09:28:05 -0400 [thread overview]
Message-ID: <20100715132804.GA2370@tuxdriver.com> (raw)
In-Reply-To: <4C3F0AA3.4050706@marvell.com>
On Thu, Jul 15, 2010 at 06:48:27PM +0530, yogeshp wrote:
> BA window size for a successful BA setup is not made available to the driver by
> mac80211. The patch below gets the BA window size from addba response and
> indicates it to driver through IEEE80211_AMPDU_TX_OPERATIONAL drv_ampdu_action.
>
> Signed-off-by: yogeshp@marvell.com
> Signed-off-by: nishants@marvell.com
This patch seems to have a lot of whitespace damage. Please
follow the normal practices, etc. Also, the Signed-off-by: line
typically includes the full name (e.g. "Signed-off-by: Full Name
<namef@marvell.com>").
I didn't look too closely at the code itself, so I'll leave it to
others to comment on that...
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-07-15 13:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 13:18 [RFC] mac80211: indicate BA window size with IEEE80211_AMPDU_TX_OPERATIONAL drv_ampud_action yogeshp
2010-07-15 13:28 ` John W. Linville [this message]
2010-07-15 16:59 ` Luis R. Rodriguez
2010-07-16 9:16 ` yogeshp
2010-07-16 17:12 ` Luis R. Rodriguez
2010-07-16 18:16 ` Helmut Schaa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100715132804.GA2370@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
--cc=pnemavat@marvell.com \
--cc=yogeshp@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).