Re: [PATCH/RFC 1/3] ath5k: log descriptor chains at a new debug level

[Bruno Randolf <br1@einfach.org>]

On Sun July 18 2010 04:35:34 Bob Copeland wrote:
> Descriptors are currently logged with ATH5K_DEBUG_RESET,
> which isn't really apt, and also means we can't see just
> the descriptor setup or just the resets.  Add a new
> debug level just for that.
> 
> Signed-off-by: Bob Copeland <me@bobcopeland.com>
> ---
>  drivers/net/wireless/ath/ath5k/debug.c |    5 +++--
>  drivers/net/wireless/ath/ath5k/debug.h |    2 ++
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath5k/debug.c
> b/drivers/net/wireless/ath/ath5k/debug.c index ebb9c23..2222022 100644
> --- a/drivers/net/wireless/ath/ath5k/debug.c
> +++ b/drivers/net/wireless/ath/ath5k/debug.c
> @@ -309,6 +309,7 @@ static const struct {
>  	{ ATH5K_DEBUG_DUMP_TX,	"dumptx",	"print transmit skb content" },
>  	{ ATH5K_DEBUG_DUMPBANDS, "dumpbands",	"dump bands" },
>  	{ ATH5K_DEBUG_ANI,	"ani",		"adaptive noise immunity" },
> +	{ ATH5K_DEBUG_DESC,	"desc",		"descriptor chains" },
>  	{ ATH5K_DEBUG_ANY,	"all",		"show all debug levels" },
>  };
> 
> @@ -937,7 +938,7 @@ ath5k_debug_printrxbuffs(struct ath5k_softc *sc, struct
> ath5k_hw *ah) struct ath5k_rx_status rs = {};
>  	int status;
> 
> -	if (likely(!(sc->debug.level & ATH5K_DEBUG_RESET)))
> +	if (likely(!(sc->debug.level & ATH5K_DEBUG_DESC)))
>  		return;
> 
>  	printk(KERN_DEBUG "rxdp %x, rxlink %p\n",
> @@ -979,7 +980,7 @@ ath5k_debug_printtxbuf(struct ath5k_softc *sc, struct
> ath5k_buf *bf) struct ath5k_tx_status ts = {};
>  	int done;
> 
> -	if (likely(!(sc->debug.level & ATH5K_DEBUG_RESET)))
> +	if (likely(!(sc->debug.level & ATH5K_DEBUG_DESC)))
>  		return;
> 
>  	done = sc->ah->ah_proc_tx_desc(sc->ah, bf->desc, &ts);
> diff --git a/drivers/net/wireless/ath/ath5k/debug.h
> b/drivers/net/wireless/ath/ath5k/debug.h index 606ae94..9b22722 100644
> --- a/drivers/net/wireless/ath/ath5k/debug.h
> +++ b/drivers/net/wireless/ath/ath5k/debug.h
> @@ -95,6 +95,7 @@ struct ath5k_dbg_info {
>   * @ATH5K_DEBUG_DUMP_TX: print transmit skb content
>   * @ATH5K_DEBUG_DUMPBANDS: dump bands
>   * @ATH5K_DEBUG_TRACE: trace function calls
> + * @ATH5K_DEBUG_DESC: descriptor setup
>   * @ATH5K_DEBUG_ANY: show at any debug level
>   *
>   * The debug level is used to control the amount and type of debugging
> output @@ -117,6 +118,7 @@ enum ath5k_debug_level {
>  	ATH5K_DEBUG_DUMP_TX	= 0x00000200,
>  	ATH5K_DEBUG_DUMPBANDS	= 0x00000400,
>  	ATH5K_DEBUG_ANI		= 0x00002000,
> +	ATH5K_DEBUG_DESC	= 0x00004000,
>  	ATH5K_DEBUG_ANY		= 0xffffffff
>  };

Acked-by: Bruno Randolf <br1@einfach.org>