Re: [ath5k-devel] [PATCH/RFC 0/3] ath5k: add driver tracepoints

[Bruno Randolf <br1@einfach.org>]

On Sun July 18 2010 04:35:33 Bob Copeland wrote:
> This series adds some tracepoints for reset and tx/rx, with an
> eye toward replacing some of the debug printks we have today.
> Stolen form iwlwifi is the idea of logging entire packets so
> we can generate pcap files from the traces, via something like:
> 
>     $ mkdir -p ~/.trace-cmd/plugins
>     $ cd ~/.trace-cmd/plugins
>     $ wget 'http://bobcopeland.com/srcs/ath5k_trace.py'
>     $ trace-cmd record -e mac80211 -e ath5k sleep 500
>     $ trace-cmd report | less
>     $ wireshark /tmp/pcap.out
> 
> I quite like the result, but I'd be interested to hear others'
> opinions on the approach.  Right now I think these tracepoints
> will be useful in seeing causes of excessive resets, and debugging
> queue hangs.

hmm, this is really nice stuff, but i'm not sure what to do on embedded boards 
where we don't have python or where it's not possible to use tracing in 
general due to (low) performance reasons. in these cases the kernel printks 
are just so much more easy to use... i would actually prefer to keep them... 
additionally to the new tracing you made, maybe? otoh we could probably get 
tracing enabled on all boards if we really need it, it's just some extra 
work...

bruno