From: "John W. Linville" <linville@tuxdriver.com>
To: "Michael Büsch" <mb@bu3sch.de>
Cc: linux-wireless@vger.kernel.org,
"Larry Finger" <Larry.Finger@lwfinger.net>,
"Gábor Stefanik" <netrolller.3d@gmail.com>,
"Rafał Miłecki" <zajec5@gmail.com>
Subject: Re: [PATCH] b43: silense most sparse warnings
Date: Wed, 21 Jul 2010 12:38:03 -0400 [thread overview]
Message-ID: <20100721163803.GC2355@tuxdriver.com> (raw)
In-Reply-To: <4C471AC2.5040003@bu3sch.de>
On Wed, Jul 21, 2010 at 06:05:22PM +0200, Michael Büsch wrote:
> On 07/21/2010 05:45 PM, John W. Linville wrote:
> >diff --git a/drivers/net/wireless/b43/phy_g.c b/drivers/net/wireless/b43/phy_g.c
> >index 29bf34c..0dc33b6 100644
> >--- a/drivers/net/wireless/b43/phy_g.c
> >+++ b/drivers/net/wireless/b43/phy_g.c
> >@@ -972,7 +972,7 @@ b43_radio_interference_mitigation_enable(struct b43_wldev *dev, int mode)
> > b43_phy_maskset(dev, 0x04A2, 0xFFF0, 0x000B);
> >
> > if (phy->rev>= 3) {
> >- b43_phy_mask(dev, 0x048A, (u16)~0x8000);
> >+ b43_phy_mask(dev, 0x048A, 0x7FFF);
>
> This cast was introduced to silense a GCC warning. Do we end up in an
> infinite loop now? ;)
This version has the beauty of pleasing both gcc and sparse. :-)
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-07-21 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 15:45 [PATCH] b43: silense most sparse warnings John W. Linville
2010-07-21 16:05 ` Michael Büsch
2010-07-21 16:38 ` John W. Linville [this message]
2010-07-21 16:48 ` Larry Finger
2010-07-21 17:11 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100721163803.GC2355@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=netrolller.3d@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).