From: "John W. Linville" <linville@tuxdriver.com>
To: Pauli Nieminen <suokkos@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rtl8180: improve signal reporting for rtl8185 hardware
Date: Wed, 21 Jul 2010 13:19:26 -0400 [thread overview]
Message-ID: <20100721171926.GE2355@tuxdriver.com> (raw)
In-Reply-To: <AANLkTint5uT6PQ8pmEIVSoVYOSCZE5k-TGB1knwHtupw@mail.gmail.com>
On Wed, Jul 21, 2010 at 08:07:56PM +0300, Pauli Nieminen wrote:
> On Wed, Jul 21, 2010 at 4:33 PM, John W. Linville
> <linville@tuxdriver.com> wrote:
> > On Wed, Jul 21, 2010 at 08:08:41AM +0300, Pauli Nieminen wrote:
> >> On Mon, Jul 19, 2010 at 11:47 PM, John W. Linville
> >> <linville@tuxdriver.com> wrote:
> >> > The existing code seemed to be somewhat based on the datasheet, but
> >> > varied substantially from the vendor-provided driver. This mirrors the
> >> > handling of the rtl8185 case from that driver, but still neglects the
> >> > specifics for the rtl8180 hardware. Those details are a bit muddled...
> >> >
> >> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
> >> > ---
> >> > drivers/net/wireless/rtl818x/rtl8180_dev.c | 11 ++++++++---
> >> > 1 files changed, 8 insertions(+), 3 deletions(-)
> >
> >> I tested this version of patch. Patch didn't apply cleanly for some
> >> reason even tough when I mnauly typed it diff looks same.
> >
> > Please try the v2 version of the patch. Some "back of the envelope"
> > math suggests that the v2 version of the patch will give numbers more
> > to your liking.
> >
> > John
> > --
> > John W. Linville Someday the world will need a hero, and you
> > linville@tuxdriver.com might be all we have. Be ready.
> >
>
> But version 2 doesn't change the fact that driver is going to report
> same signal strength even tough I know that only one wifi should have
> 100 % strength and others less than 50 %. There is only one router in
> same room with me and all others routers are a lot more father away.
> So driver is either reading wrong bits from hardware or my hardware is
> broken.
Did you try the patch? I suspect not.
I can't really decipher what problem you are reporting here with "100 %
strength and others less than 50 %". In any case, if you have RTL8185
hardware then this patch changes the signal calculation to match what
the Realtek-provided vendor driver does (which doesn't seem to match
their datasheet, FWIW). If you have a better source of information
then I am happy to receive it.
If you have RTL8180 (i.e. not RTL8185) hardware then neither version of
the patch is likely to help you much (beyond avoiding the warning you
originally reported). I hope to improve that as well in the future.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-07-21 17:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-17 7:30 RTL8180L is hitting WARN_ON in net/wireless/scan.c:575 Pauli Nieminen
2010-07-19 20:47 ` [PATCH] rtl8180: improve signal reporting for rtl8185 hardware John W. Linville
2010-07-20 20:56 ` [PATCH v2] " John W. Linville
2010-07-21 5:08 ` [PATCH] " Pauli Nieminen
2010-07-21 13:33 ` John W. Linville
2010-07-21 17:07 ` Pauli Nieminen
2010-07-21 17:19 ` John W. Linville [this message]
2010-07-21 17:44 ` Pauli Nieminen
2010-07-21 20:30 ` [RFT] rtl8180: improve signal reporting for actual rtl8180 hardware John W. Linville
2010-07-22 6:07 ` Pauli Nieminen
2010-07-21 17:22 ` [PATCH] rtl8180: improve signal reporting for rtl8185 hardware Pauli Nieminen
2010-07-19 20:48 ` RTL8180L is hitting WARN_ON in net/wireless/scan.c:575 John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100721171926.GE2355@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-wireless@vger.kernel.org \
--cc=suokkos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).