From: Dan Carpenter <error27@gmail.com>
To: Bruno Randolf <br1@einfach.org>
Cc: "Luis R. Rodriguez" <lrodriguez@atheros.com>,
Nick Kossifidis <mickflemm@gmail.com>,
Jiri Slaby <jirislaby@gmail.com>,
Bob Copeland <me@bobcopeland.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, ath5k-devel@lists.ath5k.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] ath5k: snprintf() returns largish values
Date: Fri, 23 Jul 2010 12:04:42 +0200 [thread overview]
Message-ID: <20100723095252.GA26313@bicker> (raw)
In-Reply-To: <201007231744.14922.br1@einfach.org>
On Fri, Jul 23, 2010 at 05:44:14PM +0900, Bruno Randolf wrote:
>
> i think it would be better to make sure the buffer is always big enough to
> hold all the output (it's not very variable in length), but as a safety net
> this can't hurt.
>
This is a smatch thing. I suppose someday I will fix smatch to
evaulate the strings themselves and verify that the buffer is large
enough. But for now it's nice to be able to automatically check that
the buffers don't overflow.
regards,
dan carpenter
next prev parent reply other threads:[~2010-07-23 10:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 8:52 [patch -next] ath5k: snprintf() returns largish values Dan Carpenter
2010-07-22 8:56 ` Jiri Slaby
2010-07-22 10:44 ` Dan Carpenter
2010-07-23 8:44 ` Bruno Randolf
2010-07-23 10:04 ` Dan Carpenter [this message]
2010-07-23 17:48 ` Joe Perches
2010-07-23 19:21 ` Linus Torvalds
2010-07-23 16:11 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100723095252.GA26313@bicker \
--to=error27@gmail.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=br1@einfach.org \
--cc=jirislaby@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).