Linux wireless drivers development
 help / color / mirror / Atom feed
From: Jouni Malinen <j@w1.fi>
To: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
	Coelho Luciano Roth <luciano.coelho@nokia.com>
Subject: Re: Hardware needs to know when EAP nego is complete
Date: Mon, 26 Jul 2010 07:30:48 -0700	[thread overview]
Message-ID: <20100726143047.GB7324@jm.kir.nu> (raw)
In-Reply-To: <1280142400.6475.33.camel@wimaxnb.nmp.nokia.com>

On Mon, Jul 26, 2010 at 02:06:40PM +0300, Juuso Oikarinen wrote:
> There are lots of timing issues involved, and there is a priority
> between WLAN an BT. To ensure BT A2DP and SCO work properly, BT needs to
> have enough priority at the expense of WLAN performance. While this
> works well enough when connected, during WLAN association and especially
> during EAP negotiation the priority needs to be more on the WLAN side to
> ensure reliability.

Could you please explain why EAP negotiation is a special case? It is
using data frames just like any other operation after it..

> So, what this all boils down to is that the wl1271 driver needs to know
> when the association, including the possible EAP negotations are fully
> complete, to be able to adjust the priority.

This sounds like a horrible hack and really, the unreliability during
EAP should likely fixed in some other way.

> Currently, there is no such information available to the driver. In fact
> this information is not available anywhere in the kernel level either
> (as the details of the EAP negotiation, needed keys etc are controlled
> in user-space), so the trigger would need to come from user-space.

That's not actually true.. At least when run with wpa_supplicant is
setting operation state to IF_OPER_UP when the full authentication
sequence (i.e., not only EAP, but also the following 4-way handshake
with EAPOL-Key frames) is done (and IF_OPER_DORMANT when not ready).
This is needed for other purposes to indicate when real data traffic can
be sent, e.g., for DHCP clients.

I don't think I would support the idea of using that information to
change the WLAN vs. BT priority without some additional data on what
exactly goes wrong during EAP negotiation, but at least the information
should already be in the kernel, so we do not need to change nl80211 for
this.

-- 
Jouni Malinen                                            PGP id EFC895FA

  parent reply	other threads:[~2010-07-26 14:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-26 11:06 Hardware needs to know when EAP nego is complete Juuso Oikarinen
2010-07-26 11:23 ` Johannes Berg
2010-07-26 11:42   ` Juuso Oikarinen
2010-07-26 14:30 ` Jouni Malinen [this message]
2010-07-27  5:17   ` Juuso Oikarinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100726143047.GB7324@jm.kir.nu \
    --to=j@w1.fi \
    --cc=johannes@sipsolutions.net \
    --cc=juuso.oikarinen@nokia.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luciano.coelho@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox