Re: [PATCH v5] cfg80211: Add nl80211 antenna configuration

[Bruno Randolf <br1@einfach.org>]

On Fri July 30 2010 00:04:49 Luis R. Rodriguez wrote:
> >> I don't want to do any work myself on drivers for this, can we have
> >> cfg80211/mac80211 do this for us?
> > 
> > is this not a separate issue from defining the API? you could have it do
> > this for you even now, with or without the antenna API, no?
> 
> It depends on the consumer and at what level we think the consumer
> should be doing whatever checks or changes it should. For starters I
> would expect at least a check for association within cfg80211 which
> disallows hw config changes. 

for ath5k at least, it's o.k. to change antenna configuration during 
association.

if 802.11n devices cannot change antenna setup during association, the driver 
could simply reject the configuration. but i can see that it can make sense to 
handle some of this in cfg80211 or mac80211. it should be possible to add that 
on top of my patches.

i think you are expecting to much. for now i just want to define an API which 
1) can be used right now and 2) is flexible enough to support 802.11n devices. 
as i don't work with 802.11n devices right now, please don't expect me to 
solve all 802.11n related antenna problems. as long as the API is flexible 
enough i think it can be added later as 802.11n devices are going to accept 
antenna configuration.

bruno