From: "John W. Linville" <linville@tuxdriver.com>
To: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Cc: linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH 2/2] iwlwifi: do not spuriously call ieee80211_scan_completed
Date: Wed, 18 Aug 2010 12:44:05 -0400 [thread overview]
Message-ID: <20100818164405.GA2793@tuxdriver.com> (raw)
In-Reply-To: <1282149322-17928-3-git-send-email-wey-yi.w.guy@intel.com>
On Wed, Aug 18, 2010 at 09:35:22AM -0700, Wey-Yi Guy wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> When a scan is aborted because the corresponding
> virtual interface is removed, we may still later
> attempt to tell mac80211 that the scan completed.
> This is obviously wrong, since we already told it
> that it was aborted, so don't do that.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Does this really qualify as a fix for 2.6.36? Is it a regression?
Does it generate an oops? Or loss of connectivity?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-08-18 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 16:35 [PATCH 0/2] iwlwifi fix for 2.6.35 Wey-Yi Guy
2010-08-18 16:35 ` [PATCH 1/2] iwlagn: do not check for AP mode for WEP keys Wey-Yi Guy
2010-08-18 16:40 ` Johannes Berg
2010-08-18 16:51 ` Guy, Wey-Yi
2010-08-18 16:35 ` [PATCH 2/2] iwlwifi: do not spuriously call ieee80211_scan_completed Wey-Yi Guy
2010-08-18 16:44 ` John W. Linville [this message]
2010-08-18 16:50 ` Guy, Wey-Yi
2010-08-18 16:53 ` Berg, Johannes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100818164405.GA2793@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).