linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Vivek Natarajan <Vivek.Natarajan@Atheros.com>,
	Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>,
	Luis Rodriguez <mcgrof@gmail.com>
Subject: Re: [PATCH] mac80211: fix offchannel queue stop
Date: Fri, 27 Aug 2010 18:00:55 +0530	[thread overview]
Message-ID: <20100827123054.GB3780@vasanth-laptop> (raw)
In-Reply-To: <1282909528.4377.8.camel@jlt3.sipsolutions.net>

On Fri, Aug 27, 2010 at 05:15:28PM +0530, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> Somebody noticed this problem, and I outlined
> to them how to fix it, but haven't heard back
> from them. So while I was adding the state
> field I figured I could use it to fix it.
> 
> The problem, as I understand it, is that when
> we go offchannel while the driver has a queue
> stopped, the driver will likely start draining
> the queue and then enable it while offchannel.
> This in turn will enable the interface queue,
> and that leads to transmitting data frames on
> the wrong channel.
> 
> Fix this by keeping track of offchannel status
> per interface, and not enabling the interface
> queues on interfaces that are offchannel when
> the driver enables a queue.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> Too lazy to dig out who reported this, so CCing
> a bunch of people at Atheros ...


thanks for fixing, It was me only. Somehow I forgot this.

Vasanth

  reply	other threads:[~2010-08-27 12:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-27 11:45 [PATCH] mac80211: fix offchannel queue stop Johannes Berg
2010-08-27 12:30 ` Vasanthakumar Thiagarajan [this message]
2010-08-27 12:56   ` Johannes Berg
2010-08-27 13:45     ` Vasanthakumar Thiagarajan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100827123054.GB3780@vasanth-laptop \
    --to=vasanth@atheros.com \
    --cc=Vasanth.Thiagarajan@Atheros.com \
    --cc=Vivek.Natarajan@Atheros.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mcgrof@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).