* [PATCH] mac80211: Fix signal strength average initialization for CQM events
@ 2010-08-27 19:21 Jouni Malinen
0 siblings, 0 replies; only message in thread
From: Jouni Malinen @ 2010-08-27 19:21 UTC (permalink / raw)
To: John W. Linville, Johannes Berg; +Cc: linux-wireless
The ave_beacon_signal value uses 1/16 dB unit and as such, must be
initialized with the signal level of the first Beacon frame multiplied
by 16. This fixes an issue where the initial CQM events are reported
incorrectly with a burst of events while the running average
approaches the correct value after the incorrect initialization. This
could cause user space -based roaming decision process to get quite
confused at the moment when we would like to go through authentication
and DHCP.
Cc: stable@kernel.org
Signed-off-by: Jouni Malinen <j@w1.fi>
---
net/mac80211/mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- wireless-testing.orig/net/mac80211/mlme.c 2010-08-27 15:48:14.000000000 +0300
+++ wireless-testing/net/mac80211/mlme.c 2010-08-27 21:43:54.000000000 +0300
@@ -1548,7 +1548,7 @@ static void ieee80211_rx_mgmt_beacon(str
ifmgd->last_beacon_signal = rx_status->signal;
if (ifmgd->flags & IEEE80211_STA_RESET_SIGNAL_AVE) {
ifmgd->flags &= ~IEEE80211_STA_RESET_SIGNAL_AVE;
- ifmgd->ave_beacon_signal = rx_status->signal;
+ ifmgd->ave_beacon_signal = rx_status->signal * 16;
ifmgd->last_cqm_event_signal = 0;
} else {
ifmgd->ave_beacon_signal =
--
Jouni Malinen PGP id EFC895FA
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-08-27 19:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-27 19:21 [PATCH] mac80211: Fix signal strength average initialization for CQM events Jouni Malinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).