From: Jean Tourrilhes <jt@hpl.hp.com>
To: Kees Cook <kees.cook@canonical.com>
Cc: linux-kernel@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <eric.dumazet@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>,
Joe Perches <joe@perches.com>, Tejun Heo <tj@kernel.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] wireless: fix 64K kernel heap content leak via ioctl
Date: Fri, 27 Aug 2010 14:53:16 -0700 [thread overview]
Message-ID: <20100827215316.GA32405@bougret.hpl.hp.com> (raw)
In-Reply-To: <20100827214357.GE4703@outflux.net>
On Fri, Aug 27, 2010 at 02:43:57PM -0700, Kees Cook wrote:
> Hi Jean,
>
> The comment should probably be clarified -- it's the caller's iwp->length
> that may be causing problems
Ha ! I see. It would be for regular iwpoint queries, not for
extended NOMAX queries (scan is a extended NOMAX query).
Note that I don't like the idea of reducing the mallocated
size, especially with regular queries, as I know that some driver may
expect a fixed size in extra and may memcpy to it without double
checking.
> Regardless, the above patch would appear to limit the copy_to_user
> to only the kzalloced region.
I'm glad you like it.
> Thanks!
>
> -Kees
Regards,
Jean
next prev parent reply other threads:[~2010-08-27 21:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 21:02 [PATCH] wireless: fix 64K kernel heap content leak via ioctl Kees Cook
2010-08-27 21:22 ` Jean Tourrilhes
2010-08-27 21:43 ` Kees Cook
2010-08-27 21:53 ` Jean Tourrilhes [this message]
2010-08-27 22:35 ` Luis R. Rodriguez
2010-08-27 22:39 ` Jean Tourrilhes
2010-08-27 22:51 ` Luis R. Rodriguez
2010-08-30 8:47 ` Johannes Berg
2010-08-30 8:58 ` Johannes Berg
2010-08-30 9:59 ` Johannes Berg
2010-08-30 10:24 ` [PATCH] wireless extensions: fix kernel heap content leak Johannes Berg
2010-08-30 18:03 ` Kees Cook
2010-08-30 18:06 ` Johannes Berg
2010-08-30 17:40 ` [PATCH] wireless: fix 64K kernel heap content leak via ioctl Jean Tourrilhes
2010-08-30 17:50 ` Johannes Berg
2010-09-15 22:48 ` [vendor-sec] " Greg KH
2010-09-15 23:11 ` Johannes Berg
2010-09-15 23:28 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100827215316.GA32405@bougret.hpl.hp.com \
--to=jt@hpl.hp.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=joe@perches.com \
--cc=johannes@sipsolutions.net \
--cc=kees.cook@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).