From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:64855 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753583Ab0H3Oe4 (ORCPT ); Mon, 30 Aug 2010 10:34:56 -0400 From: Helmut Schaa To: Johannes Berg Subject: Re: mac80211 using different tx queue for frames with same TID and RA Date: Mon, 30 Aug 2010 16:34:09 +0200 Cc: linux-wireless@vger.kernel.org, Krishna Kumar , netdev@vger.kernel.org References: <201008301601.12971.helmut.schaa@googlemail.com> <1283177480.3691.66.camel@jlt3.sipsolutions.net> In-Reply-To: <1283177480.3691.66.camel@jlt3.sipsolutions.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Message-Id: <201008301634.10122.helmut.schaa@googlemail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: Am Monday 30 August 2010 schrieb Johannes Berg: > On Mon, 2010-08-30 at 16:01 +0200, Helmut Schaa wrote: > > > while debugging an issue in rt2x00 I've discovered that in some cases frames > > with the same TID and RA end up in different tx queues (which causes problems > > in rt2x00 when using aggregation). > > > > Is this behavior expected and we need to handle that case in rt2x00 or is it > > more likely a bug? At least I thought the select_queue implementation in > > mac80211 was meant to always pick the same tx queue for skbs with the same > > priority and hence it shouldn't happen that frames with the same TID are > > queued into different tx queues. > > Indeed, that seems like a bug. I don't see how this can happen though, > since the code _appears_ to not use the sk_tx_queue_mapping when an > ndo_select_queue method is present. Hmm, this issue seems to only happen when the wifi interface (AP mode) is part of a bridge and the frame is tx'ed through the bridge. Helmut