Re: [PATCH 0/13] iwlwifi: rewrite iwl-scan.c to avoid race conditions

[Stanislaw Gruszka <sgruszka@redhat.com>]

On Fri, Sep 03, 2010 at 02:21:58PM +0200, Johannes Berg wrote:
> On Fri, 2010-09-03 at 13:57 +0200, Stanislaw Gruszka wrote:
> 
> [lots of patches]
> 
> Looks OK to me, apart from what I've pointed out,

All concerns are fixed by later patches.

> and I hope you've
> tested it :-) I'm not an expert on the scanning code, to be honest.

I used below script on iwl3945. I plan to make some more testing, on
iwlagn and with different scenarios. But patches improve things, it was
easy to reproduce problem with script on iwl3945, with patches problem
seems to gone.

#!/bin/bash

export my_dev=`iw dev | grep Interface | head -1 | awk '{ print $2 }'`
export my_phy=`iw dev | grep phy  | head -1 | tr -d '#'`

(while true; do iwlist ${my_dev} scan ; sleep 3 ; done) &
b1=$!
(while true; do ifconfig ${my_dev} down ; ifconfig $my_dev up ; sleep 8 ; done) &
b2=$!

mount -t debugfs debugfs /sys/kernel/debug 2> /dev/null > /dev/null

(while true; do echo 1 > /sys/kernel/debug/ieee80211/${my_phy}/iwl3945/debug/force_reset ; sleep 5 ; done ) &
b3=$!
(while true; do echo 0 > /sys/kernel/debug/ieee80211/${my_phy}/iwl3945/debug/force_reset ; sleep 13 ; done ) &
b4=$!

function exit_script ()
{
	kill -KILL $b1
	kill -KILL $b2
	kill -KILL $b3
	kill -KILL $b4
	kill -KILL $$
}

trap exit_script INT TERM EXIT

while true ; do sleep 1 ; done

exit_script