From: Bruno Randolf <br1@einfach.org>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, bob@bobcopeland.com,
ath5k-devel@lists.ath5k.org, lrodriguez@atheros.com,
mickflemm@gmail.com
Subject: [PATCH 0/8] ath: Move key cache functions to ath common
Date: Wed, 08 Sep 2010 16:04:28 +0900 [thread overview]
Message-ID: <20100908070427.11255.17659.stgit@tt-desk> (raw)
The following series moves the key cache management functions from ath9k to
the common ath/key.c so we can also use them from ath5k. Both ath5k and
ath9k are changed to use the common key functions.
This is necessary since HW encryption in ath5k was broken for AP mode and
software encryption was enabled as a workaround (in "ath5k: temporarily
disable crypto for AP mode", 65b5a69860ed3bc4224368b804d381cd9cafa90a).
Using software encryption has a performance impact, which we would like to
avoid, especially on embedded boards, which is where AP configurations are
most common. On embedded AP boards we definetly want to make use of the
chipsets HW encryption.
The symptom of the broken HW encryption was that when two clients connected
to one AP with WPA (AES or TKIP) as soon as the second client connected, the
first one was not able to send or receive packets.
Rather than trying to fix the ath5k implementation, i think it makes more
sense to share this code between ath5k and ath9k.
This series was tested with ath5k (AR5414) in AP and station mode and with
ath9k 9160 in AP mode, both with TKIP and AES. ath9k_htc was compile tested
only.
bruno
---
Bruno Randolf (8):
ath: Copy cryptographic capability flags into ath
ath: Copy key cache management functions from ath9k to ath
ath5k: Use common ath key management functions
ath5k: Remove old ath5k key handling functions
ath/ath9k: Replace common->splitmic with a flag
ath5k: Use common crypt capabilities flags
ath9k: Use common ath key management functions
ath9k: Use common crypt capabilities flags
drivers/net/wireless/ath/Makefile | 3
drivers/net/wireless/ath/ath.h | 39 ++
drivers/net/wireless/ath/ath5k/ath5k.h | 7
drivers/net/wireless/ath/ath5k/attach.c | 13 -
drivers/net/wireless/ath/ath5k/base.c | 35 +-
drivers/net/wireless/ath/ath5k/pcu.c | 191 --------
drivers/net/wireless/ath/ath5k/reg.h | 42 --
drivers/net/wireless/ath/ath9k/common.c | 270 ------------
drivers/net/wireless/ath/ath9k/common.h | 6
drivers/net/wireless/ath/ath9k/htc_drv_init.c | 2
drivers/net/wireless/ath/ath9k/htc_drv_main.c | 4
drivers/net/wireless/ath/ath9k/hw.c | 288 -------------
drivers/net/wireless/ath/ath9k/hw.h | 46 +-
drivers/net/wireless/ath/ath9k/init.c | 6
drivers/net/wireless/ath/ath9k/mac.h | 21 -
drivers/net/wireless/ath/ath9k/main.c | 4
drivers/net/wireless/ath/ath9k/phy.h | 3
drivers/net/wireless/ath/key.c | 568
+++++++++++++++++++++++++
drivers/net/wireless/ath/reg.h | 23 +
19 files changed, 686 insertions(+), 885 deletions(-)
create mode 100644 drivers/net/wireless/ath/key.c
--
next reply other threads:[~2010-09-08 7:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 7:04 Bruno Randolf [this message]
2010-09-08 7:04 ` [PATCH 1/8] ath: Copy cryptographic capability flags into ath Bruno Randolf
2010-09-08 7:04 ` [PATCH 2/8] ath: Copy key cache management functions from ath9k to ath Bruno Randolf
2010-09-08 7:04 ` [PATCH 3/8] ath5k: Use common ath key management functions Bruno Randolf
2010-09-11 17:22 ` me
2010-09-13 1:09 ` [ath5k-devel] " Bruno Randolf
2010-09-15 2:54 ` Jouni Malinen
2010-09-08 7:04 ` [PATCH 4/8] ath5k: Remove old ath5k key handling functions Bruno Randolf
2010-09-11 17:23 ` bob
2010-09-08 7:04 ` [PATCH 5/8] ath/ath9k: Replace common->splitmic with a flag Bruno Randolf
2010-09-11 17:25 ` bob
2010-09-08 7:04 ` [PATCH 6/8] ath5k: Use common crypt capabilities flags Bruno Randolf
2010-09-11 17:27 ` bob
2010-09-13 1:17 ` Bruno Randolf
2010-09-13 2:35 ` [ath5k-devel] " Bob Copeland
2010-09-08 7:05 ` [PATCH 7/8] ath9k: Use common ath key management functions Bruno Randolf
2010-09-08 7:05 ` [PATCH 8/8] ath9k: Use common crypt capabilities flags Bruno Randolf
2010-09-11 17:31 ` [PATCH 0/8] ath: Move key cache functions to ath common bob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100908070427.11255.17659.stgit@tt-desk \
--to=br1@einfach.org \
--cc=ath5k-devel@lists.ath5k.org \
--cc=bob@bobcopeland.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).