From: Jarek Poplawski <jarkao2@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
linux-kernel@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>,
"John W. Linville" <linville@tuxdriver.com>,
"David S. Miller" <davem@davemloft.net>,
Kalle Valo <kalle.valo@iki.fi>, Felix Fietkau <nbd@openwrt.org>,
Jouni Malinen <j@w1.fi>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: fix compilation warning
Date: Tue, 14 Sep 2010 06:09:48 +0000 [thread overview]
Message-ID: <20100914060948.GA6908@ff.dom.local> (raw)
In-Reply-To: <1284441432.3704.0.camel@jlt3.sipsolutions.net>
On 2010-09-14 07:17, Johannes Berg wrote:
> On Sun, 2010-09-12 at 14:10 +0300, Felipe Contreras wrote:
>
>> struct ieee80211_hdr hdr;
>> - struct ieee80211s_hdr mesh_hdr;
>> const u8 *encaps_data;
>> int encaps_len, skip_header_bytes;
>> int nh_pos, h_pos;
>> @@ -1755,7 +1754,9 @@ netdev_tx_t ieee80211_subif_start_xmit(struct sk_buff *skb,
>> hdrlen = 30;
>> break;
>> #ifdef CONFIG_MAC80211_MESH
>> - case NL80211_IFTYPE_MESH_POINT:
>> + case NL80211_IFTYPE_MESH_POINT: {
>> + struct ieee80211s_hdr mesh_hdr;
>> +
>
> ...
>
> might be nicer to just add __maybe_unused.
>
> johannes
>
Or at least more consistent with the fix in net-next ;-)
Jarek P.
prev parent reply other threads:[~2010-09-14 6:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1284289829-25425-1-git-send-email-felipe.contreras@gmail.com>
2010-09-12 11:10 ` [PATCH 2/2] mac80211: fix compilation warning Felipe Contreras
2010-09-14 5:17 ` Johannes Berg
2010-09-14 6:09 ` Jarek Poplawski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100914060948.GA6908@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=felipe.contreras@gmail.com \
--cc=j@w1.fi \
--cc=jkosina@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=kalle.valo@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).