From: Chris Ball <cjb@laptop.org>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: linux-wireless@vger.kernel.org, linux-mmc@vger.kernel.org,
Luciano Coelho <luciano.coelho@nokia.com>,
akpm@linux-foundation.org, San Mehat <san@google.com>,
Roger Quadros <roger.quadros@nokia.com>,
Nicolas Pitre <nico@fluxnic.net>,
Gao Yunpeng <yunpeng.gao@intel.com>
Subject: Re: [PATCH v1 7/8] sdio: enable Runtime PM for SDIO functions
Date: Tue, 14 Sep 2010 20:27:38 +0100 [thread overview]
Message-ID: <20100914192738.GB21918@void.printf.net> (raw)
In-Reply-To: <1283858949-11073-8-git-send-email-ohad@wizery.com>
Hi Ohad,
On Tue, Sep 07, 2010 at 02:29:08PM +0300, Ohad Ben-Cohen wrote:
> @@ -152,6 +173,11 @@ static int sdio_bus_remove(struct device *dev)
> sdio_release_host(func);
> }
>
> + pm_runtime_put_noidle(dev);
> +
> + /* Undo the runtime PM settings in sdio_bus_probe() */
> + pm_runtime_put_noidle(dev);
> +
> return 0;
> }
>
Nit: This makes sense in context, but stands out as a possible paste
accident on first sight. :) I think it's worth adding a comment to
the first call; something like:
> + /* First, undo the increment made directly above */
> + pm_runtime_put_noidle(dev);
> +
> + /* Then undo the runtime PM settings in sdio_bus_probe() */
> + pm_runtime_put_noidle(dev);
> +
Thanks,
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2010-09-14 19:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 11:29 [PATCH v1 0/8] SDIO Runtime PM Support Ohad Ben-Cohen
2010-09-07 11:29 ` [PATCH v1 1/8] mmc: sdio: fully reconfigure oldcard on resume Ohad Ben-Cohen
2010-09-07 11:29 ` [PATCH v1 2/8] mmc: propagate power save/restore ops return value Ohad Ben-Cohen
2010-09-07 11:29 ` [PATCH v1 3/8] sdio: add power_restore support Ohad Ben-Cohen
2010-09-07 11:29 ` [PATCH v1 4/8] mmc: add general Runtime PM support Ohad Ben-Cohen
2010-09-07 11:29 ` [PATCH v1 5/8] sdio: add general runtime " Ohad Ben-Cohen
2010-09-07 11:29 ` [PATCH v1 6/8] sdio: enable Runtime PM for SDIO cards Ohad Ben-Cohen
2010-09-07 11:29 ` [PATCH v1 7/8] sdio: enable Runtime PM for SDIO functions Ohad Ben-Cohen
2010-09-14 19:27 ` Chris Ball [this message]
2010-09-14 19:32 ` Ohad Ben-Cohen
2010-09-07 11:29 ` [PATCH v1 8/8] wireless: wl1271_sdio: enable Runtime PM Ohad Ben-Cohen
2010-09-07 13:02 ` David Vrabel
2010-09-07 13:15 ` Ohad Ben-Cohen
2010-09-07 22:20 ` David Vrabel
2010-09-08 17:40 ` Luciano Coelho
2010-09-08 17:52 ` [PATCH v1 0/8] SDIO Runtime PM Support Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100914192738.GB21918@void.printf.net \
--to=cjb@laptop.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@nokia.com \
--cc=nico@fluxnic.net \
--cc=ohad@wizery.com \
--cc=roger.quadros@nokia.com \
--cc=san@google.com \
--cc=yunpeng.gao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).