From: Christian Lamparter <chunkeey@googlemail.com>
To: linux-wireless@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
"John W. Linville" <linville@tuxdriver.com>
Subject: [PATCH] carl9170: use generic_file_llseek in debugfs
Date: Tue, 14 Sep 2010 23:38:03 +0200 [thread overview]
Message-ID: <201009142338.04104.chunkeey@googlemail.com> (raw)
In-Reply-To: <1284495763-7506-3-git-send-email-arnd@arndb.de>
On Tuesday 14 September 2010 22:22:30 Arnd Bergmann wrote:
> The default llseek operation is changing from
> default_llseek to no_llseek, so all code relying on
> the current behaviour needs to make that explicit.
>
> All these files use debugfs and they typically rely
> on simple_read_from_buffer, so the best llseek operation
> here is generic_file_llseek.
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
---
diff --git a/drivers/net/wireless/ath/carl9170/debug.c b/drivers/net/wireless/ath/carl9170/debug.c
index 3e9b0e8..6559381 100644
--- a/drivers/net/wireless/ath/carl9170/debug.c
+++ b/drivers/net/wireless/ath/carl9170/debug.c
@@ -181,6 +181,7 @@ static const struct carl9170_debugfs_fops carl_debugfs_##name ##_ops = {\
.open = carl9170_debugfs_open, \
.read = carl9170_debugfs_read, \
.write = carl9170_debugfs_write, \
+ .llseek = generic_file_llseek, \
.owner = THIS_MODULE \
}, \
}
next prev parent reply other threads:[~2010-09-14 21:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 20:22 [PATCH 00/15] change default_llseek action Arnd Bergmann
2010-09-14 20:22 ` [PATCH 02/15] net/wireless: use generic_file_llseek in debugfs Arnd Bergmann
2010-09-14 21:38 ` Christian Lamparter [this message]
2010-09-15 9:39 ` [PATCH 00/15] change default_llseek action Stephen Rothwell
2010-09-15 16:06 ` Luis R. Rodriguez
2010-09-15 15:38 ` Valdis.Kletnieks
2010-09-15 16:37 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009142338.04104.chunkeey@googlemail.com \
--to=chunkeey@googlemail.com \
--cc=arnd@arndb.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).