From: Bob Copeland <me@bobcopeland.com>
To: Jonathan Guerin <jonathan@guerin.id.au>
Cc: Bruno Randolf <br1@einfach.org>,
ath5k-devel <ath5k-devel@lists.ath5k.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Nick Kossifidis <mickflemm@gmail.com>
Subject: Re: [ath5k-devel] [support] ath5k contention windows
Date: Tue, 14 Sep 2010 23:04:44 -0400 [thread overview]
Message-ID: <20100915030444.GB8429@hash.localnet> (raw)
In-Reply-To: <AANLkTinZmv-o-tbR=2kso8jqZPTMdG=eKFCbM9DJ41d2@mail.gmail.com>
On Wed, Sep 15, 2010 at 11:06:21AM +1000, Jonathan Guerin wrote:
> > also i think current ath5k_hw_reset_tx_queue() is buggy and sets the AIFS
> > wrongly. it uses ah->ah_aifs + tq->tqi_aifs which is 2 + AR5K_TXQ_USEDEFAULT
> > which results in 2 + (-1). that does not make sense to me and i will post a
> > patch fixing up some of that confusion (but not the SIFS issue) today.
>
> SIFS is coming up short:
> ox230/0x28 = 14us
Just a wild guess, driver may include a small fudge factor to account
for time spent in qcu. At one point I compared all of the initvals
to those from the HAL; we're at least bug-compatible with it if there
are errors here.
> By the way, I may be completely wrong about some of these things, I'm
> just going off the understanding I have regarding the register values.
Well mostly no one has looked at them, so you may well have found
some problems.
FWIW if you use coverage classes (not default), we appear to use the
right values there.
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2010-09-15 3:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTi=azJS6bn7-=Bbb--ibACaQWqv4ZGLMUpfxynm7@mail.gmail.com>
2010-09-14 5:53 ` [support] ath5k contention windows Jonathan Guerin
2010-09-15 3:40 ` Jonathan Guerin
2010-09-15 3:48 ` [ath5k-devel] " Bruno Randolf
2010-09-14 17:39 ` Bob Copeland
2010-09-14 23:07 ` Jonathan Guerin
2010-09-15 0:44 ` Jonathan Guerin
2010-09-15 1:47 ` Bruno Randolf
2010-09-15 1:58 ` Jonathan Guerin
2010-09-14 22:48 ` Nick Kossifidis
2010-09-14 23:07 ` Jonathan Guerin
2010-09-15 0:58 ` Bruno Randolf
2010-09-15 1:06 ` Jonathan Guerin
2010-09-15 3:04 ` Bob Copeland [this message]
2010-09-15 3:20 ` Jonathan Guerin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100915030444.GB8429@hash.localnet \
--to=me@bobcopeland.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=br1@einfach.org \
--cc=jonathan@guerin.id.au \
--cc=linux-wireless@vger.kernel.org \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).