Re: [ath5k-devel] [ath5k] Incorrect value for ACK_TIMEOUT

[Bruno Randolf <br1@einfach.org>]

On Wed September 15 2010 16:27:01 Jonathan Guerin wrote:
> So, we would prefer to match the spec for an out-of-the-box build,
> even tho it would appear to be a worse-performing driving to users?

sure, we need to comply to the specs.

bruno

> --
> Jonathan Guerin
> 
> On Wed, Sep 15, 2010 at 5:17 PM, Kalle Valo <kvalo@adurom.com> wrote:
> > Jonathan Guerin <jonathan@guerin.id.au> writes:
> >>> the thing is, like bob said, that we don't really know much about what
> >>> the HW expects in some of these registers, so unless you can prove
> >>> your changes to be correct - e.g. by measurements which fit the
> >>> theoretical model better, or by better thruput, it's hard to say if
> >>> they are correct or not.
> >>> 
> >>> so before you worry about how to make a correct patch, just go ahead
> >>> and change those initvals to what you believe they should be. if it
> >>> improves something, let's talk about how to correctly fix it.
> >> 
> >> I don't mean to be a smart-ass, but wouldn't setting the correct
> >> values here decrease the throughput? I'm not quite sure how to verify
> >> an improvement, other than get the card to contend for the medium with
> >> another known-working card? Does this sound reasonable?
> > 
> > Yes, it does sound reasonable. You might get throughput increase by
> > violating the spec.
> > 
> > --
> > Kalle Valo