public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ath9k-devel@venema.h4ckr.net" <ath9k-devel@venema.h4ckr.net>
Subject: Re: [PATCH] ath9k: make ath_ant_div_conf_fast_divbias static
Date: Thu, 16 Sep 2010 10:26:48 +0530	[thread overview]
Message-ID: <20100916045648.GB30871@vasanth-laptop> (raw)
In-Reply-To: <1284578773-18629-1-git-send-email-linville@tuxdriver.com>

On Thu, Sep 16, 2010 at 12:56:13AM +0530, John W. Linville wrote:
>   CHECK   drivers/net/wireless/ath/ath9k/recv.c
> drivers/net/wireless/ath/ath9k/recv.c:1341:6: warning: symbol 'ath_ant_div_conf_fast_divbias' was not declared. Should it be static?
> 
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
>  drivers/net/wireless/ath/ath9k/recv.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
> index 6fb3b45..aa9a14d 100644
> --- a/drivers/net/wireless/ath/ath9k/recv.c
> +++ b/drivers/net/wireless/ath/ath9k/recv.c
> @@ -1338,7 +1338,7 @@ static void ath_select_ant_div_from_quick_scan(struct ath_ant_comb *antcomb,
>  	}
>  }
>  
> -void ath_ant_div_conf_fast_divbias(struct ath_hw_antcomb_conf *ant_conf)
> +static void ath_ant_div_conf_fast_divbias(struct ath_hw_antcomb_conf *ant_conf)
>  {
>  	/* Adjust the fast_div_bias based on main and alt lna conf */
>  	switch ((ant_conf->main_lna_conf << 4) | ant_conf->alt_lna_conf) {

thanks for fixing this. btw, a patch fixing this one was already
part of my 3 patch series, probably the commit log was not good
or something?

Thanks,

Vasanth

      reply	other threads:[~2010-09-16  4:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-15 19:26 [PATCH] ath9k: make ath_ant_div_conf_fast_divbias static John W. Linville
2010-09-16  4:56 ` Vasanthakumar Thiagarajan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100916045648.GB30871@vasanth-laptop \
    --to=vasanth@atheros.com \
    --cc=ath9k-devel@venema.h4ckr.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox