From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/3] ath9k: Paprd calibration should be per channel
Date: Thu, 16 Sep 2010 10:47:39 +0530 [thread overview]
Message-ID: <20100916051739.GA32605@vasanth-laptop> (raw)
In-Reply-To: <4C90E4F6.1090403@openwrt.org>
On Wed, Sep 15, 2010 at 08:53:34PM +0530, Felix Fietkau wrote:
> On 2010-09-15 4:22 PM, Vasanthakumar Thiagarajan wrote:
> > Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
> NACK. The point of the caldata struct is to keep calibration data for
> the operating channel and reset it whenever that changes (but not just
> for off-channel activity).
> Since the PAPRD data uses quite a bit of memory and doesn't take that
> long to generate, we don't really need to make it per-channel.
Yes, it takes some memory, this looked clean and simple. It is not
unusual case that we would be operating on different channels
(think about roaming,dfs,p2p and etc). The existing implementation
does not do paprd calibration when the operating channel is changed.
Having a single caldata might require us depend on SC_OP_SCANNING/
SC_OP_OFFCHANNEL, but we are already dealing with some bugs in those
flags. I completely agree that it takes memory, would try to fix
existing issues in paprd rather than keeping channel specific data.
thanks for the review.
Vasanth
next prev parent reply other threads:[~2010-09-16 5:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 14:22 [PATCH 1/3] ath9k: Fix regression in starting ANI after association Vasanthakumar Thiagarajan
2010-09-15 14:22 ` [PATCH 2/3] ath9k: Paprd calibration should be per channel Vasanthakumar Thiagarajan
2010-09-15 15:23 ` Felix Fietkau
2010-09-16 5:17 ` Vasanthakumar Thiagarajan [this message]
2010-09-16 6:47 ` Felix Fietkau
2010-09-15 14:22 ` [PATCH 3/3] ath9k: Fix sparse warning: symbol 'ath_ant_div_conf_fast_divbias' was not declared Vasanthakumar Thiagarajan
2010-09-15 16:21 ` [PATCH 1/3] ath9k: Fix regression in starting ANI after association Luis R. Rodriguez
2010-09-16 4:49 ` Vasanthakumar Thiagarajan
2010-09-16 14:19 ` Luis R. Rodriguez
2010-09-22 13:49 ` Vasanthakumar Thiagarajan
2010-09-27 17:21 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916051739.GA32605@vasanth-laptop \
--to=vasanth@atheros.com \
--cc=Vasanth.Thiagarajan@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).