linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Vipin Mehta <vmehta@atheros.com>
Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: ath6kl: Including a header file to fix a compilation error
Date: Thu, 16 Sep 2010 17:14:36 -0700	[thread overview]
Message-ID: <20100917001436.GA27148@kroah.com> (raw)
In-Reply-To: <1284682087-19351-1-git-send-email-vmehta@atheros.com>

On Thu, Sep 16, 2010 at 05:08:07PM -0700, Vipin Mehta wrote:
> The commit fixes a compilation error that was encountered while using a specific kernel configuration file. The problem was the use of some fuunctions defined in <linux/semaphore.h> without including the header file explicitly. It was probably working before because of the dependency getting implicitly satisfied via some other header file. Also, eliminating the inclusion of the same header file more than once. The code needs additional cleanup and may be addressed by a subsequent commit.

Um, please wrap your lines at 72 columns.

> 
> Signed-off-by: Vipin Mehta <vmehta@atheros.com>

Did you forget to report who pointed out the problem to you?  That needs
to go in a:
	Reported-by: Foo <foo@baz.org>
line.

Care to redo this?

thanks,

greg k-h

  parent reply	other threads:[~2010-09-17  0:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-17  0:08 [PATCH] staging: ath6kl: Including a header file to fix a compilation error Vipin Mehta
2010-09-17  0:10 ` Luis R. Rodriguez
2010-09-17  0:13   ` Vipin Mehta
2010-09-17  0:17     ` Greg KH
2010-09-17  0:14 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-09-17 16:54 Vipin Mehta
2010-09-17 17:23 ` Randy Dunlap
2010-09-17 18:00   ` Greg KH
2010-09-17 23:26     ` Vipin Mehta
2010-09-17 23:46       ` Greg KH
2010-09-18  2:06         ` Vipin Mehta
2010-09-18  5:11           ` Greg KH
2010-09-17 23:11   ` Vipin Mehta
2010-09-17 23:26     ` Greg KH
2010-09-18  2:00       ` Vipin Mehta
2010-09-18  5:12         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100917001436.GA27148@kroah.com \
    --to=greg@kroah.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=vmehta@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).