From: Greg KH <greg@kroah.com>
To: Vipin Mehta <Vipin.Mehta@Atheros.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
Subject: Re: [PATCH] staging: ath6kl: Including a header file to fix a compilation error
Date: Fri, 17 Sep 2010 16:26:43 -0700 [thread overview]
Message-ID: <20100917232643.GA25757@kroah.com> (raw)
In-Reply-To: <35B17FE5076C7040809188FBE7913F983F23937DAE@SC1EXMB-MBCL.global.atheros.com>
On Fri, Sep 17, 2010 at 04:11:57PM -0700, Vipin Mehta wrote:
> > Hi,
> > Thanks for the patch, but I still get these errors & warnings:
> >
> > on linux-next 2010-0915:
> >
> > drivers/staging/ath6kl/hif/sdio/linux_sdio/src/hif_scatter.c: In function
> > 'SetupHIFScatterSupport':
> > drivers/staging/ath6kl/hif/sdio/linux_sdio/src/hif_scatter.c:288: error:
> > 'struct mmc_host' has no member named 'max_hw_segs'
> > drivers/staging/ath6kl/hif/sdio/linux_sdio/src/hif_scatter.c:289: error:
> > 'struct mmc_host' has no member named 'max_hw_segs'
> >
> This is because of a recent change in the mmc_host structure that removes the distinction between hw and phys segments. The structure is different in the staging-next-2.6 tree which is where I usually build and test the changes.
Please, fix your email client to wrap lines at a sane place...
> Greg,
> The two trees linux-next and staging-next are not in sync so what is
> the process that is usually followed under these circumstances? I see
> little point in using the staging-next-2.6 tree to generate and test
> my patches since the tree eventually drains into linux-next. Should I
> stop worrying about if the patch works for the staging-next tree and
> just focus on that things should work with linux-next?
If the problem is due to another change in a different tree, send me the
patch and I'll hold on to it until the mmc tree is merged with Linus
(during the .37 merge window) and then I'll apply it and push it out.
Until then, we can ask Stephen to hold the patch in linux-next to fix
the build issue.
But I'd still like the .h file fixup patch to be resolved and in my tree
first, right?
thanks,
greg k-h
next prev parent reply other threads:[~2010-09-17 23:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 16:54 [PATCH] staging: ath6kl: Including a header file to fix a compilation error Vipin Mehta
2010-09-17 17:23 ` Randy Dunlap
2010-09-17 18:00 ` Greg KH
2010-09-17 23:26 ` Vipin Mehta
2010-09-17 23:46 ` Greg KH
2010-09-18 2:06 ` Vipin Mehta
2010-09-18 5:11 ` Greg KH
2010-09-17 23:11 ` Vipin Mehta
2010-09-17 23:26 ` Greg KH [this message]
2010-09-18 2:00 ` Vipin Mehta
2010-09-18 5:12 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2010-09-17 0:08 Vipin Mehta
2010-09-17 0:10 ` Luis R. Rodriguez
2010-09-17 0:13 ` Vipin Mehta
2010-09-17 0:17 ` Greg KH
2010-09-17 0:14 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100917232643.GA25757@kroah.com \
--to=greg@kroah.com \
--cc=Vipin.Mehta@Atheros.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-wireless@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).