[PATCH] staging: ath6kl: Fixing a compile error

[PATCH] staging: ath6kl: Fixing a compile error

[Vipin Mehta]

Fixing a typo that came in as part of commit
fa1ae16c97d25bb57ed9e1971b9e814da6a290bd.

Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Vipin Mehta <vmehta@atheros.com>
---
 drivers/staging/ath6kl/wmi/wmi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/ath6kl/wmi/wmi.c b/drivers/staging/ath6kl/wmi/wmi.c
index 9811ce7..23ae5d2 100644
--- a/drivers/staging/ath6kl/wmi/wmi.c
+++ b/drivers/staging/ath6kl/wmi/wmi.c
@@ -1458,7 +1458,7 @@ wmi_bssInfo_event_rx(struct wmi_t *wmip, A_UINT8 *datap, int len)
 
 	A_DPRINTF(DBG_WMI2, (DBGFMT "bssInfo event - ch %u, rssi %02x, "
 		"bssid \"%pM\"\n", DBGARG, bih->channel,
-		(unsigned char) bih->rssi, i&bih->bssid[0]));
+		(unsigned char) bih->rssi, &bih->bssid[0]));
 
     if(wps_enable && (bih->frameType == PROBERESP_FTYPE) ) {
         wmi_node_return(wmip, bss);
-- 
1.6.3.3

Re: [PATCH] staging: ath6kl: Fixing a compile error

[Andy Shevchenko]

Yeah, but this is fixed in my correction series.
Whole store there:

http://lkml.org/lkml/2010/9/16/330
http://lkml.org/lkml/2010/9/17/54

On Sat, Sep 18, 2010 at 4:06 AM, Vipin Mehta <vmehta@atheros.com> wrote:
> Fixing a typo that came in as part of commit
> fa1ae16c97d25bb57ed9e1971b9e814da6a290bd.
>
> Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
> Signed-off-by: Vipin Mehta <vmehta@atheros.com>
> ---
>  drivers/staging/ath6kl/wmi/wmi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/ath6kl/wmi/wmi.c b/drivers/staging/ath6kl/wmi/wmi.c
> index 9811ce7..23ae5d2 100644
> --- a/drivers/staging/ath6kl/wmi/wmi.c
> +++ b/drivers/staging/ath6kl/wmi/wmi.c
> @@ -1458,7 +1458,7 @@ wmi_bssInfo_event_rx(struct wmi_t *wmip, A_UINT8 *datap, int len)
>
>        A_DPRINTF(DBG_WMI2, (DBGFMT "bssInfo event - ch %u, rssi %02x, "
>                "bssid \"%pM\"\n", DBGARG, bih->channel,
> -               (unsigned char) bih->rssi, i&bih->bssid[0]));
> +               (unsigned char) bih->rssi, &bih->bssid[0]));
>
>     if(wps_enable && (bih->frameType == PROBERESP_FTYPE) ) {
>         wmi_node_return(wmip, bss);
> --
> 1.6.3.3
>
>



-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] staging: ath6kl: Fixing a compile error

[Greg KH]

On Sat, Sep 18, 2010 at 11:41:40AM +0300, Andy Shevchenko wrote:
> Yeah, but this is fixed in my correction series.
> Whole store there:
> 
> http://lkml.org/lkml/2010/9/16/330
> http://lkml.org/lkml/2010/9/17/54

Yes, I've now applied this one, thanks.

greg k-h

[PATCH] staging: ath6kl: Fixing a compile error

[Vipin Mehta]

The commit fixes a compilation error that was encountered while using
a specific kernel configuration file. The problem was the use of some
functions defined in <linux/semaphore.h> without including the header
file explicitly. It was probably working before because of the
dependency getting implicitly satisfied via some other header file.

Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Vipin Mehta <vmehta@atheros.com>
---
 .../staging/ath6kl/os/linux/include/osapi_linux.h  |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/ath6kl/os/linux/include/osapi_linux.h b/drivers/staging/ath6kl/os/linux/include/osapi_linux.h
index ef7cc82..fce6ceb 100644
--- a/drivers/staging/ath6kl/os/linux/include/osapi_linux.h
+++ b/drivers/staging/ath6kl/os/linux/include/osapi_linux.h
@@ -39,7 +39,7 @@
 #include <linux/timer.h>
 #include <linux/delay.h>
 #include <linux/wait.h>
-
+#include <linux/semaphore.h>
 #include <linux/cache.h>
 
 #ifdef __GNUC__
-- 
1.6.3.3