linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: chunkeey@googlemail.com
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: pull request: wireless-next-2.6 2010-09-21
Date: Wed, 22 Sep 2010 09:22:52 -0700 (PDT)	[thread overview]
Message-ID: <20100922.092252.116390431.davem@davemloft.net> (raw)
In-Reply-To: <201009221158.13806.chunkeey@googlemail.com>

From: Christian Lamparter <chunkeey@googlemail.com>
Date: Wed, 22 Sep 2010 11:58:13 +0200

> On Wednesday 22 September 2010 03:36:14 David Miller wrote:
>> From: "John W. Linville" <linville@tuxdriver.com>
>> Date: Tue, 21 Sep 2010 16:17:05 -0400
>> 
>> Pulled, but I suspect the 'packed' attribute usage is wrong in
>> ath/carl9170 and can just be deleted.
> 
> which __packed do you think can be removed?
> 
> Note:
> The overzealous use of __packed is a result of a report from Al Viro
> for ar9170usb: "arm will pad even between u8's".

Then only the structure that has the "u8's" needs the __packed attribute
not every single other structure it is included in.

  parent reply	other threads:[~2010-09-22 16:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-21 20:17 pull request: wireless-next-2.6 2010-09-21 John W. Linville
2010-09-22  1:36 ` David Miller
2010-09-22  9:58   ` Christian Lamparter
2010-09-22 10:01     ` Johannes Berg
2010-09-22 10:27       ` Christian Lamparter
2010-09-22 10:34         ` Johannes Berg
2010-09-22 11:09           ` Christian Lamparter
2010-09-22 16:22     ` David Miller [this message]
2010-09-22 18:54       ` Christian Lamparter
2010-09-22 19:19         ` David Miller
2010-09-22 20:46           ` Christian Lamparter
2010-09-22 20:57             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100922.092252.116390431.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=chunkeey@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).