From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
<nbd@openwrt.org>
Subject: Re: [PATCH 1/3] ath9k: Fix regression in starting ANI after association
Date: Wed, 22 Sep 2010 19:19:27 +0530 [thread overview]
Message-ID: <20100922134927.GA18450@vasanth-laptop> (raw)
In-Reply-To: <AANLkTim8xb3V_QpFm3BEx+W4PD6a3n+JRuZqPDkamtwu@mail.gmail.com>
On Thu, Sep 16, 2010 at 07:49:39PM +0530, Luis R. Rodriguez wrote:
> On Wed, Sep 15, 2010 at 9:49 PM, Vasanthakumar Thiagarajan
> <vasanth@atheros.com> wrote:
> > On Wed, Sep 15, 2010 at 09:51:43PM +0530, Luis R. Rodriguez wrote:
> >> On Wed, Sep 15, 2010 at 7:22 AM, Vasanthakumar Thiagarajan
> >> <vasanth@atheros.com> wrote:
> >> > Author: Felix Fietkau <nbd@openwrt.org>
> >> > Date: Sat Jul 31 00:11:59 2010 +0200
> >> >
> >> > ath9k: prevent calibration during off-channel activity
> >> >
> >> > The above patch checks for off-channel before starting ANI,
> >> > but when the operating channel is set right after association,
> >> > IEEE80211_CONF_OFFCHANNEL would be set as still local->tmp_channel
> >> > is non-NULL. This would result in not starting calibration after
> >> > the association.
> >
> > Yes, the bug is in mac80211, but fixing this one in mac80211 looks
> > not straight forward and probably Felix would know this one better,
> > for now let me do this in driver and remove it once it is cleanly
> > fixed in mac80211.
>
> No, please address in mac80211, if we clean this up as a work around
> we likely are overlooking other possible issues which can be affected
> as well.
It is not easy (from my understanding at least) to fix this in
mac80211 as the assumption of off-channel activity (IEEE80211_CONF_OFFCHANNEL)
itself seems to be wrong sometimes (in case of station mode, setting this flag
before the association does not look right). As I dont know any
clean fix in mac80211, this patch can be an interim fix for the
regression.
Vasanth
next prev parent reply other threads:[~2010-09-22 13:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 14:22 [PATCH 1/3] ath9k: Fix regression in starting ANI after association Vasanthakumar Thiagarajan
2010-09-15 14:22 ` [PATCH 2/3] ath9k: Paprd calibration should be per channel Vasanthakumar Thiagarajan
2010-09-15 15:23 ` Felix Fietkau
2010-09-16 5:17 ` Vasanthakumar Thiagarajan
2010-09-16 6:47 ` Felix Fietkau
2010-09-15 14:22 ` [PATCH 3/3] ath9k: Fix sparse warning: symbol 'ath_ant_div_conf_fast_divbias' was not declared Vasanthakumar Thiagarajan
2010-09-15 16:21 ` [PATCH 1/3] ath9k: Fix regression in starting ANI after association Luis R. Rodriguez
2010-09-16 4:49 ` Vasanthakumar Thiagarajan
2010-09-16 14:19 ` Luis R. Rodriguez
2010-09-22 13:49 ` Vasanthakumar Thiagarajan [this message]
2010-09-27 17:21 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100922134927.GA18450@vasanth-laptop \
--to=vasanth@atheros.com \
--cc=Vasanth.Thiagarajan@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).