* [PATCH] carl9170: interrupt urbs must not set URB_ZERO_PACKET
@ 2010-09-27 23:53 Christian Lamparter
0 siblings, 0 replies; only message in thread
From: Christian Lamparter @ 2010-09-27 23:53 UTC (permalink / raw)
To: linux-wireless; +Cc: John W. Linville
This patch fixes a bug in the driver which was
exposed by CONFIG_USB_DEBUG:
"usb 1-1.6.3: BOGUS urb flags, 40 --> 0"
The transfer flag "URB_ZERO_PACKET" is only valid
for bulk urbs.
Reported-by: André Erdmann
Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
---
diff --git a/drivers/net/wireless/ath/carl9170/usb.c b/drivers/net/wireless/ath/carl9170/usb.c
--- a/drivers/net/wireless/ath/carl9170/usb.c
+++ b/drivers/net/wireless/ath/carl9170/usb.c
@@ -606,8 +606,6 @@ int __carl9170_exec_cmd(struct ar9170 *ar, struct carl9170_cmd *cmd,
AR9170_USB_EP_CMD), cmd, cmd->hdr.len + 4,
carl9170_usb_cmd_complete, ar, 1);
- urb->transfer_flags |= URB_ZERO_PACKET;
-
if (free_buf)
urb->transfer_flags |= URB_FREE_BUFFER;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-09-27 23:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-27 23:53 [PATCH] carl9170: interrupt urbs must not set URB_ZERO_PACKET Christian Lamparter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).