* [PATCH] iwlwifi: change WARN_ON to IWL_WARN in iwl_mac_add_interface
@ 2010-09-30 14:27 Stanislaw Gruszka
2010-09-30 23:52 ` Guy, Wey-Yi
0 siblings, 1 reply; 2+ messages in thread
From: Stanislaw Gruszka @ 2010-09-30 14:27 UTC (permalink / raw)
To: Wey-Yi Guy; +Cc: linux-wireless
We can start restarting firmware or RF kill switch can be turned on
during call to iwl_mac_add_interface(). That are normal working
conditions, so do not print call trace, just print simple message
instead.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
drivers/net/wireless/iwlwifi/iwl-core.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-core.c b/drivers/net/wireless/iwlwifi/iwl-core.c
index 5c56893..b7adcf8 100644
--- a/drivers/net/wireless/iwlwifi/iwl-core.c
+++ b/drivers/net/wireless/iwlwifi/iwl-core.c
@@ -2003,7 +2003,8 @@ int iwl_mac_add_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif)
mutex_lock(&priv->mutex);
- if (WARN_ON(!iwl_is_ready_rf(priv))) {
+ if (!iwl_is_ready_rf(priv)) {
+ IWL_WARN(priv, "Try to add interface when device not ready\n");
err = -EINVAL;
goto out;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iwlwifi: change WARN_ON to IWL_WARN in iwl_mac_add_interface
2010-09-30 14:27 [PATCH] iwlwifi: change WARN_ON to IWL_WARN in iwl_mac_add_interface Stanislaw Gruszka
@ 2010-09-30 23:52 ` Guy, Wey-Yi
0 siblings, 0 replies; 2+ messages in thread
From: Guy, Wey-Yi @ 2010-09-30 23:52 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: linux-wireless@vger.kernel.org
On Thu, 2010-09-30 at 07:27 -0700, Stanislaw Gruszka wrote:
> We can start restarting firmware or RF kill switch can be turned on
> during call to iwl_mac_add_interface(). That are normal working
> conditions, so do not print call trace, just print simple message
> instead.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> ---
> drivers/net/wireless/iwlwifi/iwl-core.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-core.c b/drivers/net/wireless/iwlwifi/iwl-core.c
> index 5c56893..b7adcf8 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-core.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-core.c
> @@ -2003,7 +2003,8 @@ int iwl_mac_add_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif)
>
> mutex_lock(&priv->mutex);
>
> - if (WARN_ON(!iwl_is_ready_rf(priv))) {
> + if (!iwl_is_ready_rf(priv)) {
> + IWL_WARN(priv, "Try to add interface when device not ready\n");
> err = -EINVAL;
> goto out;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-30 23:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-30 14:27 [PATCH] iwlwifi: change WARN_ON to IWL_WARN in iwl_mac_add_interface Stanislaw Gruszka
2010-09-30 23:52 ` Guy, Wey-Yi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).