linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Bill Jordan <bjordan@rajant.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Luis Rodriguez <Luis.Rodriguez@Atheros.com>
Subject: Re: [PATCH 2/3] cfg80211: patches to allow setting the WDS peer
Date: Thu, 30 Sep 2010 17:25:26 -0700	[thread overview]
Message-ID: <20101001002526.GC8930@tux> (raw)
In-Reply-To: <1285885755.5137.23.camel@jlt3.sipsolutions.net>

On Thu, Sep 30, 2010 at 03:29:15PM -0700, Johannes Berg wrote:
> On Thu, 2010-09-30 at 18:21 -0400, Bill Jordan wrote:
> 
> >  net/wireless/nl80211.c  |   49 +++++++++++++++++++++++++++++++++++++++++++++++
> 
> > --- a/net/wireless/nl80211.c
> > +++ b/net/wireless/nl80211.c
> > @@ -603,6 +603,7 @@ static int nl80211_send_wiphy(struct sk_buff *msg,
> > u32 pid, u32 seq, int flags,
> >  		NLA_PUT_U32(msg, i, NL80211_CMD_SET_WIPHY_NETNS);
> >  	}
> >  	CMD(set_channel, SET_CHANNEL);
> > +	CMD(set_wds_peer, SET_WDS_PEER);
> > 
> >  #undef CMD
> > 
> > @@ -831,6 +832,48 @@ static int nl80211_set_channel(struct sk_buff
> > *skb, struct genl_info *info)
> >  	return result;
> >  }
> > 
> 
> This patch was somehow cut short.
> 
> Also, your patches are line-wrapped, which means they cannot be applied.
> 
> You can find information on fixing that in
> Documentation/email-clients.txt, but gmail web interface simply cannot
> work.

You can use git sende-mail as documented on that link I gave you, Bill.
> 
> Finally, it'd be nice if you could thread your patches into the thread
> opened by the 0/N patch. Maybe look at quilt?

And this is accomplished with --no-chain-reply-to git send-email as
mentioned in the same guide.

  Luis

  reply	other threads:[~2010-10-01  0:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-30 22:21 [PATCH 2/3] cfg80211: patches to allow setting the WDS peer Bill Jordan
2010-09-30 22:29 ` Johannes Berg
2010-10-01  0:25   ` Luis R. Rodriguez [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-10-01 15:20 [PATCH 0/3] patches for WDS interfaces Bill Jordan
2010-10-01 15:20 ` [PATCH 2/3] cfg80211: patches to allow setting the WDS peer Bill Jordan
2010-10-01 16:05   ` Johannes Berg
2010-10-01 16:06     ` Johannes Berg
2010-10-01 17:45       ` Bill Jordan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101001002526.GC8930@tux \
    --to=lrodriguez@atheros.com \
    --cc=Luis.Rodriguez@Atheros.com \
    --cc=bjordan@rajant.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).