From: Tony Lindgren <tony@atomide.com>
To: Anand Gadiyar <gadiyar@ti.com>
Cc: linux-omap@vger.kernel.org, linux-wireless@vger.kernel.org,
Ohad Ben-Cohen <ohad@wizery.com>
Subject: Re: [PATCH] omap: zoom2/3: fix build caused by wl1271 support
Date: Fri, 1 Oct 2010 16:10:26 -0700 [thread overview]
Message-ID: <20101001231026.GH3117@atomide.com> (raw)
In-Reply-To: <1285965206-17777-1-git-send-email-gadiyar@ti.com>
* Anand Gadiyar <gadiyar@ti.com> [101001 13:25]:
> Patch "omap: zoom: add mmc3/wl1271 device support" in the
> wireless tree still uses .wires in struct omap2_hsmmc_info.
> .wires has now been replaced with .caps in patch "omap: mmc:
> extended to pass host capabilities from board file" in the
> OMAP tree.
>
> This causes linux-next as of 20101001 build to break as
> below. Fix this.
>
> CC arch/arm/mach-omap2/board-zoom-peripherals.o
> arch/arm/mach-omap2/board-zoom-peripherals.c:217: error: unknown field 'wires' specified in initializer
> make[1]: *** [arch/arm/mach-omap2/board-zoom-peripherals.o] Error 1
> make: *** [arch/arm/mach-omap2] Error 2
Can you guys please queue this via the wireless tree along with
the other wl1271 patches?
Acked-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> Cc: Ohad Ben-Cohen <ohad@wizery.com>
> Cc: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/mach-omap2/board-zoom-peripherals.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/arch/arm/mach-omap2/board-zoom-peripherals.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-omap2/board-zoom-peripherals.c
> +++ linux-2.6/arch/arm/mach-omap2/board-zoom-peripherals.c
> @@ -214,7 +214,7 @@ static struct omap2_hsmmc_info mmc[] __i
> {
> .name = "wl1271",
> .mmc = 3,
> - .wires = 4,
> + .caps = MMC_CAP_4_BIT_DATA,
> .gpio_wp = -EINVAL,
> .gpio_cd = -EINVAL,
> .nonremovable = true,
next prev parent reply other threads:[~2010-10-01 23:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 20:33 [PATCH] omap: zoom2/3: fix build caused by wl1271 support Anand Gadiyar
2010-10-01 23:10 ` Tony Lindgren [this message]
2010-10-05 11:53 ` Luciano Coelho
2010-10-05 12:07 ` Luciano Coelho
2010-10-05 13:19 ` Luciano Coelho
2010-10-05 20:39 ` Luciano Coelho
2010-10-06 13:52 ` John W. Linville
2010-10-06 14:01 ` Gadiyar, Anand
2010-10-06 15:27 ` Luciano Coelho
2010-10-06 15:30 ` John W. Linville
2010-10-06 15:55 ` Luciano Coelho
2010-10-06 19:34 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101001231026.GH3117@atomide.com \
--to=tony@atomide.com \
--cc=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).