From: Bruno Randolf <br1@einfach.org>
To: Felix Fietkau <nbd@openwrt.org>
Cc: Vasanthakumar Thiagarajan <vasanth@atheros.com>,
Vasanth Thiagarajan <Vasanth.Thiagarajan@atheros.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Luis Rodriguez <Luis.Rodriguez@atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>
Subject: Re: [PATCH 2/4] ath9k_hw: merge codepaths that access the cycle counter registers
Date: Tue, 5 Oct 2010 18:59:14 +0900 [thread overview]
Message-ID: <201010051859.14594.br1@einfach.org> (raw)
In-Reply-To: <4CA9CDDC.4000302@openwrt.org>
On Mon October 4 2010 21:51:40 Felix Fietkau wrote:
> On 2010-10-04 2:24 PM, Vasanthakumar Thiagarajan wrote:
> >> >> + /* unfreeze counters */
> >> >> + REG_WRITE(ah, AR_MIBC, 0);
> >> >
> >> > Please configure the relevant bit to unfreeze the counters.
> >>
> >> What do you mean?
> >
> > AR_MIBC does more than just freeze/unfreeze the counters, though I
> > dont see any issues with setting the whole register to zero, it
> > looks buggy. Please configure only the relevant bit to
> > freeze/unfreeze the counters.
>
> Other places in the code set it to zero as well, though sometimes
> written in a weird way. I also checked the specs, there is no bit that's
> supposed to be active at this point.
hi!
i just sent a patch series, which moves that function to common, to be shared
between ath5k and ath9k. i implemented it in a rather simple way, i admit, but
it hope that it is sufficient anyways. the patch series should also include
what is left from this patch. could you please check and let me know what you
think?
thanks,
bruno
prev parent reply other threads:[~2010-10-05 9:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-03 17:07 [PATCH 1/4] ath9k_hw: clean up calibration flags Felix Fietkau
2010-10-03 17:07 ` [PATCH 2/4] ath9k_hw: merge codepaths that access the cycle counter registers Felix Fietkau
2010-10-03 17:07 ` [PATCH 3/4] ath9k_hw: clean up register write buffering Felix Fietkau
2010-10-03 17:07 ` [PATCH 4/4] ath9k_hw: fix regression in ANI listen time calculation Felix Fietkau
2010-10-03 17:24 ` Luis R. Rodriguez
2010-10-03 19:08 ` Felix Fietkau
2010-10-03 19:10 ` Felix Fietkau
2010-10-04 8:56 ` [PATCH 3/4] ath9k_hw: clean up register write buffering Rajkumar Manoharan
2010-10-04 11:53 ` Felix Fietkau
2010-10-04 17:22 ` [PATCH v2 " Felix Fietkau
2010-10-05 4:38 ` Senthil Balasubramanian
2010-10-05 10:03 ` [PATCH v3 " Felix Fietkau
2010-10-06 20:32 ` John W. Linville
2010-10-04 6:34 ` [PATCH 2/4] ath9k_hw: merge codepaths that access the cycle counter registers Vasanthakumar Thiagarajan
2010-10-04 8:17 ` Adrian Chadd
2010-10-04 11:36 ` Felix Fietkau
2010-10-04 12:24 ` Vasanthakumar Thiagarajan
2010-10-04 12:51 ` Felix Fietkau
2010-10-05 9:59 ` Bruno Randolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010051859.14594.br1@einfach.org \
--to=br1@einfach.org \
--cc=Luis.Rodriguez@atheros.com \
--cc=Vasanth.Thiagarajan@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
--cc=vasanth@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).