From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Florian Mickler <florian@mickler.org>
Cc: linville@tuxdriver.com, stable@kernel.org,
linux-wireless@vger.kernel.org, wey-yi.w.guy@intel.com,
reinette.chatre@intel.com, ilw@linux.intel.com,
johannes.berg@intel.com, ben.m.cahill@intel.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: fix iwlwifi scanning corner cases
Date: Wed, 6 Oct 2010 11:02:35 +0200 [thread overview]
Message-ID: <20101006090228.GA2523@redhat.com> (raw)
In-Reply-To: <1286317292-10679-1-git-send-email-florian@mickler.org>
Hi Florian
On Wed, Oct 06, 2010 at 12:21:32AM +0200, Florian Mickler wrote:
> Stanislaw Gruszka pointed out, that commit
> "iwl3945: queue the right work if the scan needs to be aborted"
> has an awkward definition of "right". Specifically the abort_scan work
> doesn't notify the generic wireless stack that the scan was aborted.
>
> In order to get rid of the warning in bug
> https://bugzilla.kernel.org/show_bug.cgi?id=17722
> we inform ieee80211_scan_completed that we are aborting
> the scan by setting the apropriate status bit in request_scan and
> pass it into ieee80211_scan_completed.
>
> Signed-off-by: Florian Mickler <florian@mickler.org>
> ---
>
> Hi John!
>
> Here is the fix that Stanislaw described.
> (Yes, it is in a brown paper bag.) Please wait for him to review this.
>
> Another option would be to just revert my previous patch and live with the
> warning until the scanning rework hit's mainline.
This patch is not so bad, but better would be just return value from
{iwlagn,iwl3945}_request_scan instead of queuing anything. I will
prepare patch(s) today or tomorrow.
Stanislaw
next prev parent reply other threads:[~2010-10-06 9:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 6:43 Fw: [PATCH] iwl3945: queue the right work if the scan needs to be aborted Florian Mickler
2010-10-05 8:57 ` Stanislaw Gruszka
2010-10-05 10:12 ` Florian Mickler
2010-10-05 10:43 ` Stanislaw Gruszka
2010-10-05 22:29 ` Florian Mickler
2010-10-05 22:21 ` [PATCH] iwlwifi: fix iwlwifi scanning corner cases Florian Mickler
2010-10-06 9:02 ` Stanislaw Gruszka [this message]
2010-10-06 16:04 ` [PATCH wireless-2.6 or stable] iwlwifi: return error when fail to start scanning Stanislaw Gruszka
2010-10-06 16:12 ` Guy, Wey-Yi
2010-10-06 17:32 ` Florian Mickler
2010-10-06 17:45 ` Florian Mickler
2010-10-06 17:48 ` Guy, Wey-Yi
2010-10-06 20:01 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006090228.GA2523@redhat.com \
--to=sgruszka@redhat.com \
--cc=ben.m.cahill@intel.com \
--cc=florian@mickler.org \
--cc=ilw@linux.intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=stable@kernel.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).