linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Lamparter <chunkeey@googlemail.com>
To: linux-wireless@vger.kernel.org
Cc: linville@tuxdriver.com, Ben Greear <greearb@candelatech.com>,
	Ming Lei <tom.leiming@gmail.com>
Subject: [PATCH] mac80211: hoist sta->lock from reorder release timer
Date: Wed, 6 Oct 2010 12:00:53 +0200	[thread overview]
Message-ID: <201010061200.54364.chunkeey@googlemail.com> (raw)

The patch "mac80211: AMPDU rx reorder timeout timer" clashes
with "mac80211: use netif_receive_skb in ieee80211_rx callpath"

The timer itself is part of the station's private struct.
The clean-up routine will deactivate the timer as soon as
the station is removed. Therefore the extra sta->lock
protection should not be necessary.

Cc: Ben Greear <greearb@candelatech.com>
Reported-by: Ming Lei<tom.leiming@gmail.com>
Signed-off-by: Christian Lamparter<chunkeey@googlemail.com>
---
reference from Ben Greear: (no tested-by, because no-one
could actually reproduce the original lockdep warning)
http://www.spinics.net/lists/linux-wireless/msg56900.html
---
diff --git a/net/mac80211/agg-rx.c b/net/mac80211/agg-rx.c
index 58eab9e..309ed70 100644
--- a/net/mac80211/agg-rx.c
+++ b/net/mac80211/agg-rx.c
@@ -129,9 +129,7 @@ static void sta_rx_agg_reorder_timer_expired(unsigned long data)
 			timer_to_tid[0]);
 
 	rcu_read_lock();
-	spin_lock(&sta->lock);
 	ieee80211_release_reorder_timeout(sta, *ptid);
-	spin_unlock(&sta->lock);
 	rcu_read_unlock();
 }
 

             reply	other threads:[~2010-10-06 10:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-06 10:00 Christian Lamparter [this message]
2010-10-06 10:10 ` [PATCH] mac80211: hoist sta->lock from reorder release timer Johannes Berg
2010-10-06 10:20   ` Christian Lamparter
2010-10-06 10:41     ` Johannes Berg
2010-10-06 11:43       ` Christian Lamparter
2010-10-06 11:46         ` Johannes Berg
2010-10-06 20:21           ` John W. Linville
2010-10-07 21:03             ` Johannes Berg
2010-10-08 16:42               ` Christian Lamparter
2010-10-08 16:53                 ` Johannes Berg
2010-10-08 18:12                   ` Christian Lamparter
2010-10-08 18:45                     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201010061200.54364.chunkeey@googlemail.com \
    --to=chunkeey@googlemail.com \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).