From: "John W. Linville" <linville@tuxdriver.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Senthil Balasubramanian <senthilkumar@atheros.com>,
Rajkumar Manoharan <Rajkumar.Manoharan@atheros.com>,
Luis Rodriguez <Luis.Rodriguez@atheros.com>
Subject: Re: [PATCH v3 3/4] ath9k_hw: clean up register write buffering
Date: Wed, 6 Oct 2010 16:32:40 -0400 [thread overview]
Message-ID: <20101006203240.GM2472@tuxdriver.com> (raw)
In-Reply-To: <4CAAF7FE.1050105@openwrt.org>
On Tue, Oct 05, 2010 at 12:03:42PM +0200, Felix Fietkau wrote:
> Throughout the code, DISABLE_REGWRITE_BUFFER is always called right after
> REGWRITE_BUFFER_FLUSH. Since that's unlikely to change any time soon, that
> makes keeping those ops separate rather pointless, as it only increases
> code size and line number counts.
>
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> ---
> drivers/net/wireless/ath/ath.h | 4 +---
> drivers/net/wireless/ath/ath9k/ani.c | 6 ------
> drivers/net/wireless/ath/ath9k/ar5008_phy.c | 9 ++-------
> drivers/net/wireless/ath/ath9k/ar9002_calib.c | 1 -
> drivers/net/wireless/ath/ath9k/ar9002_hw.c | 4 ----
> drivers/net/wireless/ath/ath9k/ar9002_phy.c | 1 -
> drivers/net/wireless/ath/ath9k/calib.c | 1 -
> drivers/net/wireless/ath/ath9k/eeprom_4k.c | 2 --
> drivers/net/wireless/ath/ath9k/htc_drv_init.c | 12 ++----------
> drivers/net/wireless/ath/ath9k/hw.c | 14 --------------
> drivers/net/wireless/ath/ath9k/hw.h | 10 ++--------
> drivers/net/wireless/ath/ath9k/mac.c | 4 ----
> 12 files changed, 7 insertions(+), 61 deletions(-)
>
> v2: removed mwrite_cnt test
> v3: removed comment about it from description
Several patch hunks are buggered...examples:
> diff --git a/drivers/net/wireless/ath/ath9k/ani.c b/drivers/net/wireless/ath/ath9k/ani.c
> index 9936297..61e7a48 100644
> --- a/drivers/net/wireless/ath/ath9k/ani.c
> +++ b/drivers/net/wireless/ath/ath9k/ani.c
> @@ -180,7 +180,6 @@ static void ath9k_ani_restart_old(struct ath_hw *ah)
> REG_WRITE(ah, AR_PHY_ERR_MASK_2, AR_PHY_ERR_CCK_TIMING);
> REGWRITE_BUFFER_FLUSH(ah);
> - DISABLE_REGWRITE_BUFFER(ah);
> ath9k_hw_update_mibstats(ah, &ah->ah_mibStats);
> @@ -215,7 +214,6 @@ static void ath9k_ani_restart_new(struct ath_hw *ah)
> REG_WRITE(ah, AR_PHY_ERR_MASK_2, AR_PHY_ERR_CCK_TIMING);
> REGWRITE_BUFFER_FLUSH(ah);
> - DISABLE_REGWRITE_BUFFER(ah);
> ath9k_hw_update_mibstats(ah, &ah->ah_mibStats);
> @@ -643,7 +641,6 @@ static void ath9k_ani_reset_old(struct ath_hw *ah, bool is_scanning)
> REG_WRITE(ah, AR_PHY_ERR_MASK_2, AR_PHY_ERR_CCK_TIMING);
> REGWRITE_BUFFER_FLUSH(ah);
> - DISABLE_REGWRITE_BUFFER(ah);
> }
> /*
I applied the v2 version, but w/ the modification to the commit log.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-10-06 20:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-03 17:07 [PATCH 1/4] ath9k_hw: clean up calibration flags Felix Fietkau
2010-10-03 17:07 ` [PATCH 2/4] ath9k_hw: merge codepaths that access the cycle counter registers Felix Fietkau
2010-10-03 17:07 ` [PATCH 3/4] ath9k_hw: clean up register write buffering Felix Fietkau
2010-10-03 17:07 ` [PATCH 4/4] ath9k_hw: fix regression in ANI listen time calculation Felix Fietkau
2010-10-03 17:24 ` Luis R. Rodriguez
2010-10-03 19:08 ` Felix Fietkau
2010-10-03 19:10 ` Felix Fietkau
2010-10-04 8:56 ` [PATCH 3/4] ath9k_hw: clean up register write buffering Rajkumar Manoharan
2010-10-04 11:53 ` Felix Fietkau
2010-10-04 17:22 ` [PATCH v2 " Felix Fietkau
2010-10-05 4:38 ` Senthil Balasubramanian
2010-10-05 10:03 ` [PATCH v3 " Felix Fietkau
2010-10-06 20:32 ` John W. Linville [this message]
2010-10-04 6:34 ` [PATCH 2/4] ath9k_hw: merge codepaths that access the cycle counter registers Vasanthakumar Thiagarajan
2010-10-04 8:17 ` Adrian Chadd
2010-10-04 11:36 ` Felix Fietkau
2010-10-04 12:24 ` Vasanthakumar Thiagarajan
2010-10-04 12:51 ` Felix Fietkau
2010-10-05 9:59 ` Bruno Randolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006203240.GM2472@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Luis.Rodriguez@atheros.com \
--cc=Rajkumar.Manoharan@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
--cc=senthilkumar@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).