From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: use netif_receive_skb in ieee80211_tx_status callpath
Date: Thu, 7 Oct 2010 11:27:09 -0400 [thread overview]
Message-ID: <20101007152708.GA20950@tuxdriver.com> (raw)
In-Reply-To: <1286457457.20974.2.camel@jlt3.sipsolutions.net>
On Thu, Oct 07, 2010 at 03:17:37PM +0200, Johannes Berg wrote:
> On Thu, 2010-10-07 at 15:16 +0200, Johannes Berg wrote:
> > On Thu, 2010-06-24 at 14:47 -0400, John W. Linville wrote:
> > > This avoids the extra queueing from calling netif_rx.
> >
> > John, can you please revert this? It's causing issues because we don't
> > necessarily have BHs disabled here with all drivers (see below).
> > Depending on the RCU implementation, it might disable BHs, but not all
> > of them do or need to.
> >
> > Alternatively, we can require drivers to call ieee80211_tx_status() with
> > BHs disabled, but somebody would have to go through them...
>
> For RX, we do this with ieee80211_rx_ni().
Right. I thought I had checked all these contexts, but ath9k in
particular is a bit complicated to trace all the potential callpaths
by hand.
I'll revert it, and the rtl8180 patch to use napi (which also does
tx status in that context).
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-10-07 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 18:47 [PATCH 2/2] mac80211: use netif_receive_skb in ieee80211_tx_status callpath John W. Linville
2010-10-07 13:16 ` Johannes Berg
2010-10-07 13:17 ` Johannes Berg
2010-10-07 15:27 ` John W. Linville [this message]
2010-10-07 18:00 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101007152708.GA20950@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).