From: Senthil Balasubramanian <senthilkumar@atheros.com>
To: Rajkumar Manoharan <rmanoharan@atheros.com>
Cc: Felix Fietkau <nbd@openwrt.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>
Subject: Re: [PATCH 3/3] ath9k: add missing locking around ath9k_hw_proc_mib_event
Date: Wed, 13 Oct 2010 12:13:08 +0530 [thread overview]
Message-ID: <20101013064308.GA2878@senthil-lnx.users.atheros.com> (raw)
In-Reply-To: <20101013052030.GA9021@vmraj-lnx.users.atheros.com>
On Wed, Oct 13, 2010 at 10:50:31AM +0530, Rajkumar Manoharan wrote:
> On Tue, Oct 12, 2010 at 07:38:03PM +0530, Felix Fietkau wrote:
> > + spin_lock(&common->cc_lock);
> > ath9k_hw_proc_mib_event(ah);
> > + spin_unlock(&common->cc_lock);
> > ath9k_hw_set_interrupts(ah, ah->imask);
> > }
> >
> shouldn't we lock ath9k_ani_reset which also restarts ani?
Remember syncrhonizing ath9k_ani_reset() with spin_lock requires careful
review as ath9k_htc uses mutex lock somewhere in the ani reset path.
>
> - Rajkumar
> > --
> > 1.7.2.2
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-10-13 6:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 14:08 [PATCH 1/3] ath9k_hw: fix division by zero in the ANI monitor code Felix Fietkau
2010-10-12 14:08 ` [PATCH 2/3] ath9k_hw: fix PHY counter overflow handling in ANI v1 Felix Fietkau
2010-10-12 14:08 ` [PATCH 3/3] ath9k: add missing locking around ath9k_hw_proc_mib_event Felix Fietkau
2010-10-13 5:20 ` Rajkumar Manoharan
2010-10-13 6:43 ` Senthil Balasubramanian [this message]
2010-10-13 10:01 ` Felix Fietkau
2010-10-13 12:39 ` Senthil Balasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013064308.GA2878@senthil-lnx.users.atheros.com \
--to=senthilkumar@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
--cc=rmanoharan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).