From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:49555 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932103Ab0JOQ6J (ORCPT ); Fri, 15 Oct 2010 12:58:09 -0400 From: Christian Lamparter To: Tejun Heo Subject: Re: [PATCH v2.6.36-rc7] mac80211: cancel restart_work explicitly instead of depending on flush_scheduled_work() Date: Fri, 15 Oct 2010 18:58:44 +0200 Cc: Johannes Berg , Linux Wireless List , lkml , "John W. Linville" References: <4CB874C0.8090003@kernel.org> <1287159715.1870.11.camel@Nokia-N900-51-1> <4CB883C9.6050104@kernel.org> In-Reply-To: <4CB883C9.6050104@kernel.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Message-Id: <201010151858.45000.chunkeey@googlemail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Friday 15 October 2010 18:39:37 Tejun Heo wrote: > Hello, > >> - /* > >> - * For key todo, it'll be empty by now but the work > >> - * might still be scheduled. > >> - */ > >> - flush_scheduled_work(); > > > > oops, todo work no longer exists... > > > > Anyway, ACK. > > Are you going to route this through wireless tree? Shall I repost > with update patch description? wireless-testing/wireless-next has already such a patch: "mac80211: cancel restart_work in ieee80211_unregister_hw" (2010-08-25) John, can you please push to 2.6.36-rc8? (I know, I am _late_, but I didn't know about any potential problem in the mainline?) Best regards, Chr